This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions)#47029
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Oct 17, 2023
Conversation
https://skia.googlesource.com/skia.git/+log/b524e0af7d3a..f62b4dce5e55 2023-10-17 [email protected] Fix MakeClientBasedUnicode when skia_use_client_icu is set. 2023-10-17 [email protected] Fix Segment intersection calculation 2023-10-17 [email protected] Fix availability macro use 2023-10-17 [email protected] Fix more ClangTidy `performance-unnecessary-value-param` findings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-b581f81b-a322-420f-a89a-d6a9e43f9321-1697578227
branch
from
981f089 to
f8ee8d0
Compare
fluttergithubbot
approved these changes
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2023
flutter/engine@e57b5ba...5df7af3 2023-10-17 [email protected] Roll buildroot to pull in //gpu removal. (flutter/engine#47014) 2023-10-17 [email protected] Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
https://skia.googlesource.com/skia.git/+log/b524e0af7d3a..f62b4dce5e55 2023-10-17 [email protected] Fix MakeClientBasedUnicode when skia_use_client_icu is set. 2023-10-17 [email protected] Fix Segment intersection calculation 2023-10-17 [email protected] Fix availability macro use 2023-10-17 [email protected] Fix more ClangTidy `performance-unnecessary-value-param` findings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-b581f81b-a322-420f-a89a-d6a9e43f9321-1697578227
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/b524e0af7d3a..f62b4dce5e55
2023-10-17 [email protected] Fix MakeClientBasedUnicode when skia_use_client_icu is set.
2023-10-17 [email protected] Fix Segment intersection calculation
2023-10-17 [email protected] Fix availability macro use
2023-10-17 [email protected] Fix more ClangTidy
performance-unnecessary-value-paramfindings.If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md