This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Rect getters#47411
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Oct 28, 2023
Merged
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 28, 2023
flutter/engine@a768211...03de8a4 2023-10-28 [email protected] [Impeller] Rect getters (flutter/engine#47411) 2023-10-28 [email protected] Roll Fuchsia Mac SDK from fw9lcUvz8S07_zaAj... to 9YSl2rN0sj5YpYNdQ... (flutter/engine#47409) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from fw9lcUvz8S07 to 9YSl2rN0sj5Y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor change that will allow us to migrate all of the Impeller sources off of accessing the
originandsizefields in preparation for improving the implementation ofRect.No code has been migrated to use the new fields yet, and so this code should be completely benign as is, but there will be a number of follow-on PRs that all share this PR as a pre-requisite and so it needs to be landed independently of any of the PRs that will modify code currently in use.