This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
|
@maintainer please review this PR. |
Contributor
Author
|
@zanderso @dkwingsmt Can you please review my PR? |
zanderso
approved these changes
Oct 31, 2023
Contributor
Author
|
@zanderso thanks man! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2023
flutter/engine@4da3e5b...39be0fc 2023-10-31 [email protected] [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495) 2023-10-31 [email protected] [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430) 2023-10-31 [email protected] [Typo fixed] in DEPS (flutter/engine#47440) 2023-10-31 [email protected] [Impeller] Restore GLES GPU query times. (flutter/engine#47511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Oct 31, 2023
…7635) flutter/engine@4da3e5b...39be0fc 2023-10-31 [email protected] [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495) 2023-10-31 [email protected] [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430) 2023-10-31 [email protected] [Typo fixed] in DEPS (flutter/engine#47440) 2023-10-31 [email protected] [Impeller] Restore GLES GPU query times. (flutter/engine#47511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo has been fixed.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.