This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Reduce warnings produced by unit tests#47724
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Nov 7, 2023
Merged
[Windows] Reduce warnings produced by unit tests#47724auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
loic-sharma
commented
Nov 6, 2023
| InSequence s; | ||
| EXPECT_CALL(*surface_manager.get(), MakeCurrent).WillOnce(Return(true)); | ||
| EXPECT_CALL(*surface_manager.get(), SetVSyncEnabled(true)).Times(1); | ||
| EXPECT_CALL(*surface_manager.get(), MakeCurrent).WillOnce(Return(true)); |
Member
Author
There was a problem hiding this comment.
This was making a GL context current, thereby causing other tests to complain that a GL context was unexpectedly current.
loic-sharma
changed the title
loic-sharma
force-pushed
the
windows_mock_expectations
branch
from
e7632f2 to
0769d11
Compare
loic-sharma
commented
Nov 6, 2023
| }); | ||
| EXPECT_CALL(win32window, OnResize).Times(AnyNumber()); | ||
|
|
||
| win32window.SetView(&delegate); |
Member
Author
There was a problem hiding this comment.
This was moved down as it also calls OnWindowStateEvent.
cbracken
reviewed
Nov 7, 2023
cbracken
reviewed
Nov 7, 2023
| return &delegate; | ||
| }); | ||
| EXPECT_CALL(*window_binding_handler, GetAlertDelegate) | ||
| .WillOnce(Return(&delegate)); |
Member
There was a problem hiding this comment.
Similar question here and a couple other places below.
cbracken
approved these changes
Nov 7, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Awesome -- thanks for cleaning these up! lgtm!
yaakovschectman
approved these changes
Nov 7, 2023
loic-sharma
force-pushed
the
windows_mock_expectations
branch
from
7754495 to
c974af2
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 8, 2023
flutter/engine@3e3be5e...117d47a 2023-11-08 [email protected] Roll Skia from fce71a80b0a2 to a4cce5236dcf (1 revision) (flutter/engine#47807) 2023-11-08 [email protected] [macOS] Clean up resources in ViewController tests (flutter/engine#47792) 2023-11-08 [email protected] Roll Skia from f3d250126ba9 to fce71a80b0a2 (1 revision) (flutter/engine#47796) 2023-11-08 [email protected] Roll Skia from b4fa927468e6 to f3d250126ba9 (1 revision) (flutter/engine#47793) 2023-11-08 [email protected] [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate conversion (flutter/engine#47775) 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47791) 2023-11-08 [email protected] [web] fix clicks on merged semantic nodes (attempt #2) (flutter/engine#47360) 2023-11-08 [email protected] Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (flutter/engine#47788) 2023-11-08 [email protected] Roll Fuchsia Linux SDK from VcFEJiUUTYwkhEAlJ... to sD8HRA4JmXczujkqO... (flutter/engine#47785) 2023-11-08 [email protected] Fix narrowing conversion lint (flutter/engine#47740) 2023-11-08 [email protected] [macOS] Bail out of tests if engine not running (flutter/engine#47771) 2023-11-08 [email protected] Roll Skia from f91d39395e85 to 0f78e5f765d3 (1 revision) (flutter/engine#47776) 2023-11-08 [email protected] [testing] Extract StreamCapture test utility (flutter/engine#47774) 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Promote fuchsia build v2 to prod." (flutter/engine#47779) 2023-11-08 [email protected] Include updated locations for dart third_party components into license ignore-list. (flutter/engine#47770) 2023-11-07 [email protected] Remove Fuchsia Mac SDK from DEPS (flutter/engine#47700) 2023-11-07 [email protected] Roll Skia from 030e21befbc9 to f91d39395e85 (6 revisions) (flutter/engine#47769) 2023-11-07 [email protected] [Impeller] Support static thread safety analysis with condition variables. (flutter/engine#47763) 2023-11-07 [email protected] Promote fuchsia build v2 to prod. (flutter/engine#47729) 2023-11-07 [email protected] [Windows] Reduce warnings produced by unit tests (flutter/engine#47724) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VcFEJiUUTYwk to sD8HRA4JmXcz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains no functional changes but improves existing unit tests to reduce the number of warnings output when the tests are ran:
ON_CALLwithEXPECT_CALLfor expected method callsPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.