Remove implements of JS types on @staticInterop classes#47869
Remove implements of JS types on @staticInterop classes#47869srujzs merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
srujzs
force-pushed
the
removeimplementsjstypes
branch
2 times, most recently
from
0483854 to
73fab11
Compare
JS types are going to become extension types and as such, @staticInterop types cannot implement these types. When we migrate these classes to extension types, we can add back the subtyping.
srujzs
force-pushed
the
removeimplementsjstypes
branch
from
73fab11 to
f9d9ecf
Compare
|
Sorry to make the code uglier here, but there's a bit of pain to get through so we can move forward to extension types. |
flutter/engine@de9c4d6...b020893 2023-11-10 [email protected] Remove implements of JS types on @staticInterop classes (flutter/engine#47869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
JS types are going to become extension types and as such, @staticInterop types cannot implement these types. When we migrate these classes to extension types, we can add back the subtyping.
Enables dart-lang/sdk#52687.