This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] remove drawable latency (and partial repaint).#47976
Closed
jonahwilliams wants to merge 3 commits intoflutter:mainfrom
Closed
[Impeller] remove drawable latency (and partial repaint).#47976jonahwilliams wants to merge 3 commits intoflutter:mainfrom
jonahwilliams wants to merge 3 commits intoflutter:mainfrom
Conversation
added 2 commits
November 13, 2023 14:34
Contributor
Author
|
FYI @luckysmg , this is a bit of a hack right now - but I'm interested if you'd be curious to try it. This changes the flutter engine to follow apple best practices and defer drawable aquisition as late as possible. For cases where there are no platform views, this should entirely remove the visible waitForNextDrawable delay (partially by moving this to a worker thread). |
Contributor
|
Oh. I will have a try later ^_^ |
Contributor
|
Tested this branch on iOS 17.1.1 iPhone15ProMax. Seems works fine^_^ |
This was referenced Nov 15, 2023
Contributor
Author
|
#48141 is a cleaned up version of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quickly hacked together proof of concept of deferring drawable aquisition to the last possible second. This comes at the cost of removing partial repaint, as we can't tell which framebuffer we'll be given until we're done with all work.
lots of playground and embedder code was commented out - this isn't strictly necessary but reduced the scope of changes for experimentation.