This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Try replacing *desc with value/is_valid checks.#48194
Merged
matanlurey merged 2 commits intoflutter:mainfrom Nov 21, 2023
Merged
[Impeller] Try replacing *desc with value/is_valid checks.#48194matanlurey merged 2 commits intoflutter:mainfrom
*desc with value/is_valid checks.#48194matanlurey merged 2 commits intoflutter:mainfrom
Conversation
matanlurey
added
the
test: all
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
I moved [`scene_context.h` to another PR](#48194), and here are the boring remains.
Contributor
Author
|
@bdero @jonahwilliams Friendly ping :) |
Contributor
|
test-exempt: fixing a disabled lint so that we can enable it |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2023
flutter/engine@f3e9b38...3348fb0 2023-11-21 [email protected] [Impeller] Try replacing `*desc` with value/is_valid checks. (flutter/engine#48194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some discussion here: https://discord.com/channels/608014603317936148/1175215129135153202.
In short,
*<std::optional>is undefined behavior. After talking to @bdero we are considering that this should never happen.I thought of a few different approaches here, none of them are great. However given that this class is used quite minimally, this seems to jive with similar patterns we're using in scene/scene_context.
Feel free to push back or suggest alternatives, mostly proposing this to get brain juices flowing.