[canvaskit] Enable multiview rendering by harryterkelsen · Pull Request #48301 · flutter/engine

harryterkelsen · 2023-11-22T00:45:46Z

Allows the CanvasKitRenderer to render into multiple views.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

lib/web_ui/lib/src/engine/canvaskit/rasterizer.dart

lib/web_ui/lib/src/engine/canvaskit/renderer.dart

lib/web_ui/lib/src/engine/platform_dispatcher.dart

lib/web_ui/test/canvaskit/embedded_views_test.dart

lib/web_ui/lib/src/engine/canvaskit/rasterizer.dart

lib/web_ui/lib/src/engine/canvaskit/renderer.dart

lib/web_ui/lib/src/engine/html/renderer.dart

lib/web_ui/lib/src/engine/skwasm/skwasm_impl/renderer.dart

yjbanov · 2023-11-22T23:44:26Z

lib/web_ui/lib/src/engine/canvaskit/renderer.dart

+  /// Returns the [Rasterizer] that has been created for the given [view].
+  /// Used in tests.
+  Rasterizer debugGetRasterizerForView(EngineFlutterView view) {
+    return _getRasterizerForView(view);


Should this look in the map directly? Delegating to _getRasterizerForView will actually end up creating a new rasterizer.

No because the test which uses this needs to get a hold of the Rasterizer before the first time renderScene is called so it isn't created yet.

ditman

LGTM if CI is happy! Minor comments, and a question raised by @goderbauer during the view resizing work!

lib/web_ui/lib/src/engine/platform_dispatcher.dart

lib/web_ui/test/canvaskit/common.dart

lib/web_ui/test/canvaskit/multi_view_test.dart

yjbanov

https://skia.googlesource.com/skia.git/+log/3a79d7a618aa..5606ef899116 2023-11-22 [email protected] Reland "[graphite] Use colorspace matrix to handle RGB swizzle." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

- Auto-generate view IDs. - Views don't auto-register/auto-unregister anymore. - Remove `EnginePlatformDispatcher.registerView/unregisterView` methods. - Add `FlutterViewManager.createAndRegisterView/disposeAndUnregisterView/dispose` methods. - Hook the `addView`/`removeView` JS APIs to `FlutterViewManager`.

…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…... (flutter#48338) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) https://skia.googlesource.com/skia.git/+log/b18b594b230d..0eea0b277d7d 2023-11-26 [email protected] Use SkToInt to avoid warning in Flutter roll. 2023-11-26 [email protected] Update SKP version 2023-11-26 [email protected] Roll vulkan-deps from 2e96f5c2b566 to 860dca03b6e7 (1 revision) 2023-11-26 [email protected] IWYU for modules/skshaper 2023-11-25 [email protected] Roll vulkan-deps from 95073d786075 to 2e96f5c2b566 (1 revision) 2023-11-24 [email protected] Roll vulkan-deps from 2ddf0aa40843 to 95073d786075 (2 revisions) 2023-11-24 [email protected] Avoid combining extremely large meshes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…... (flutter#48389) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… support (flutter#48388) This extension only implies decal support for OES textures. Remove it from the check for generic decal support. In practice i think it would be unlikely that a driver supports this and not regular decal, but that would only make the bugs this may cause even harder to track down.

…ter#48288) Don't branch on uniform for decal support in GLES backend.

…e. (flutter#48386) Now rendering textured 3D models! * Combined depth+stencil attachment. * Allow for multiple color attachments. * Add blend mode configuration. * Fix uniform ordering for vertex shaders. * Texture binding and sampling options. * Index buffer binding. * Depth configuration.

) https://skia.googlesource.com/skia.git/+log/0eea0b277d7d..b3e896c2f9bf 2023-11-27 [email protected] Roll SK Tool from df6df054b2af to 19a06c962732 2023-11-27 [email protected] Roll Dawn from d45b02c819f7 to 2a21ac0c3b4f (21 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/b3e896c2f9bf..2bf9afca2bc1 2023-11-27 [email protected] Roll vulkan-deps from 860dca03b6e7 to fab2f1d6619c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/2bf9afca2bc1..9fa62ccefe59 2023-11-27 [email protected] Roll ANGLE from aa3bebf94d2f to 9a70fc904664 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#43301) Fixes flutter/flutter#129710 Fixes flutter/flutter#138936 Implements https://flutter.dev/go/optimized-platform-view-layers ## Example This scene would normally require 5 surfaces, but with the PR it comes down to 2 (when drawing over platform views) and 1 when all drawing is outside of platform views). https://github.com/flutter/flutter/assets/96958/091da832-bfbc-44a2-8da5-d55d84024c96 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

https://skia.googlesource.com/skia.git/+log/9fa62ccefe59..5f0832787d0f 2023-11-27 [email protected] [bazel] Move //bazel/configs/devicesrc to //bazel/devicesrc. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/5f0832787d0f..b0d81aba3f78 2023-11-27 [email protected] [graphite] Auto-set the protectedness of Devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…flutter#48402) Manual roll requested by [email protected] https://dart.googlesource.com/sdk.git/+log/f1fd14505782..c9bdb5884670 2023-11-23 [email protected] Version 3.3.0-162.0.dev 2023-11-23 [email protected] Version 3.3.0-161.0.dev 2023-11-23 [email protected] Version 3.3.0-160.0.dev 2023-11-22 [email protected] Version 3.3.0-159.0.dev 2023-11-22 [email protected] Version 3.3.0-158.0.dev 2023-11-21 [email protected] Version 3.3.0-157.0.dev 2023-11-21 [email protected] Version 3.3.0-156.0.dev 2023-11-21 [email protected] Version 3.3.0-155.0.dev 2023-11-21 [email protected] Version 3.3.0-154.0.dev 2023-11-21 [email protected] Version 3.3.0-153.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) https://skia.googlesource.com/skia.git/+log/b0d81aba3f78..743fc1cde518 2023-11-27 [email protected] Reland "[graphite] Add no-yield option to ContextOptions." 2023-11-27 [email protected] Explicitly set defines for FontMgrs in G3 2023-11-27 [email protected] Reland "[graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Forgot about the winding order. partially reverts flutter#46282 See flutter/flutter#138598 Reopens flutter/flutter#135458

) https://skia.googlesource.com/skia.git/+log/743fc1cde518..4c964f8c4738 2023-11-27 [email protected] SkSVGDevice: don't skip fill-opacity when fill is black 2023-11-27 [email protected] [graphite] Add Graphite variants of VkProtectedContext tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/engine@0a098bd...2be7191 2023-11-27 [email protected] Dynamic view sizing [dart:ui] (flutter/engine#48090) 2023-11-27 [email protected] Roll shaderc to google/shaderc@37e2553 (flutter/engine#48415) 2023-11-27 [email protected] Roll Skia from 4c964f8c4738 to 600986ba305d (6 revisions) (flutter/engine#48419) 2023-11-27 [email protected] [canvaskit] Enable multiview rendering (flutter/engine#48301) 2023-11-27 [email protected] [Impeller] updated gaussian blur tests to use device private textures (flutter/engine#48417) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…9103) flutter/engine@0a098bd...2be7191 2023-11-27 [email protected] Dynamic view sizing [dart:ui] (flutter/engine#48090) 2023-11-27 [email protected] Roll shaderc to google/shaderc@37e2553 (flutter/engine#48415) 2023-11-27 [email protected] Roll Skia from 4c964f8c4738 to 600986ba305d (6 revisions) (flutter/engine#48419) 2023-11-27 [email protected] [canvaskit] Enable multiview rendering (flutter/engine#48301) 2023-11-27 [email protected] [Impeller] updated gaussian blur tests to use device private textures (flutter/engine#48417) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

harryterkelsen added 5 commits November 16, 2023 15:28

WIP add multiview to renderer

2dacc82

Merge branch 'main' into canvaskit-renderer-multiview

913ad52

WIP

d0b625e

Merge branch 'main' into canvaskit-renderer-multiview

241ed34

WIP multiview rendering

9deb9c7

github-actions bot added the platform-web Code specifically for the web engine label Nov 22, 2023

harryterkelsen requested review from ditman, mdebbar and yjbanov November 22, 2023 00:46

mdebbar reviewed Nov 22, 2023

View reviewed changes

harryterkelsen added 6 commits November 22, 2023 10:08

Merge branch 'main' into canvaskit-renderer-multiview

29dd070

Respond to comments

edb64ec

Fix tests

bca01da

Added basic unit test for multiview rendering

373b740

Merge branch 'main' into canvaskit-renderer-multiview

fa27c2b

Remove unused import in test

28101a0

harryterkelsen requested a review from mdebbar November 22, 2023 22:34

yjbanov reviewed Nov 22, 2023

View reviewed changes

harryterkelsen mentioned this pull request Nov 22, 2023

Support multiview rendering in the Skwasm renderer flutter/flutter#138925

Closed

2 tasks

harryterkelsen added 5 commits November 22, 2023 16:02

Respond to comments

fe52616

Add trailing commas so dartfmt doesn't explode

225cd17

Undo dartfmt

0e5ec2c

trailing whitespace

71da65c

trailing whitespace

ea3791a

ditman approved these changes Nov 23, 2023

View reviewed changes

lib/web_ui/lib/src/engine/platform_dispatcher.dart Show resolved Hide resolved

lib/web_ui/test/canvaskit/common.dart Show resolved Hide resolved

lib/web_ui/test/canvaskit/common.dart Show resolved Hide resolved

lib/web_ui/test/canvaskit/multi_view_test.dart Show resolved Hide resolved

yjbanov approved these changes Nov 27, 2023

View reviewed changes

skia-flutter-autoroll and others added 4 commits November 27, 2023 10:31

Fix not being able to hide iOS status bar via setEnabledSystemUIMode (f…

bcfb4fa

…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

skia-flutter-autoroll and others added 16 commits November 27, 2023 10:31

[Impeller] use spec constant for decal support in morph filter. (flut…

84feadc

…ter#48288) Don't branch on uniform for decal support in GLES backend.

[Impeller] revert non-zero tessellation optimization. (flutter#48234)

eb13bc2

Forgot about the winding order. partially reverts flutter#46282 See flutter/flutter#138598 Reopens flutter/flutter#135458

Respond to review comments

a28b802

github-actions bot added platform-ios platform-android e: impeller labels Nov 27, 2023

harryterkelsen and others added 2 commits November 27, 2023 11:00

Fix TODOs and changed EngineFlutterView constructor

0e59f27

Merge branch 'main' into canvaskit-renderer-multiview

bcf62a7

github-actions bot removed platform-ios platform-android e: impeller labels Nov 27, 2023

harryterkelsen merged commit 37002c3 into flutter:main Nov 27, 2023

engine-flutter-autoroll mentioned this pull request Nov 27, 2023

Roll Flutter Engine from 0a098bd6f761 to 2be719150ea9 (5 revisions) flutter/flutter#139103

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 27, 2023

37002c3 [canvaskit] Enable multiview rendering (flutter/engine#48301)

c4fd773

harryterkelsen mentioned this pull request Nov 28, 2023

[web:multi-view] Teach Renderer to target multiple elements flutter/flutter#137378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[canvaskit] Enable multiview rendering#48301

[canvaskit] Enable multiview rendering#48301
harryterkelsen merged 48 commits intoflutter:mainfrom
harryterkelsen:canvaskit-renderer-multiview

harryterkelsen commented Nov 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yjbanov Nov 22, 2023

Uh oh!

harryterkelsen Nov 22, 2023

Uh oh!

ditman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yjbanov left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

harryterkelsen commented Nov 22, 2023

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yjbanov Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants