This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delete third_party/colorama, it appears unused.#48841
Closed
matanlurey wants to merge 1 commit intoflutter:mainfrom
Closed
Delete third_party/colorama, it appears unused.#48841matanlurey wants to merge 1 commit intoflutter:mainfrom
third_party/colorama, it appears unused.#48841matanlurey wants to merge 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
Welp, it appears used in a way that is not discoverable by [29/5284] ACTION //flutter/shell/platform/android:flutter_shell_java(//build/toolchain/android:clang_arm)
FAILED: gen/flutter/shell/platform/android/flutter_shell_java.d flutter_embedding_profile.jar flutter_embedding_profile.jar.md5.stamp flutter_embedding_profile-sources.jar flutter_embedding_profile-sources.jar.md5.stamp
vpython3 ../../build/android/gyp/javac.py --depfile=gen/flutter/shell/platform/android/flutter_shell_java.d --jar-path=flutter_embedding_profile.jar --jar-source-path=flutter_embedding_profile-sources.jar --jar-source-base-dir=/b/s/w/ir/cache/builder/src/flutter/shell/platform/android --classpath=\[\"../../third_party/android_tools/sdk/platforms/android-34/android.jar\",\ \"../../third_party/android_tools/sdk/build-tools/34.0.0/core-lambda-stubs.jar\",\ \"../../third_party/android_embedding_dependencies/lib/kotlinx-coroutines-core-jvm-1.5.2.jar\",\ \"../../third_party/android_embedding_dependencies/lib/loader-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/kotlin-stdlib-common-1.5.31.jar\",\ \"../../third_party/android_embedding_dependencies/lib/collection-1.1.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/core-common-2.1.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-viewmodel-2.1.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/kotlinx-coroutines-android-1.5.2.jar\",\ \"../../third_party/android_embedding_dependencies/lib/annotation-experimental-1.1.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/versionedparcelable-1.1.1.jar\",\ \"../../third_party/android_embedding_dependencies/lib/fragment-1.1.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/core-1.6.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/core-runtime-2.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/window-1.0.0-beta04.jar\",\ \"../../third_party/android_embedding_dependencies/lib/viewpager-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/savedstate-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/tracing-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/kotlin-stdlib-jdk8-1.5.30.jar\",\ \"../../third_party/android_embedding_dependencies/lib/annotation-1.2.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/core-1.8.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-common-2.2.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/activity-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/annotations-13.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-livedata-2.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/window-java-1.0.0-beta04.jar\",\ \"../../third_party/android_embedding_dependencies/lib/LICENSE\",\ \"../../third_party/android_embedding_dependencies/lib/kotlin-stdlib-jdk7-1.5.30.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-common-java8-2.2.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/kotlin-stdlib-1.5.31.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-livedata-core-2.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/customview-1.0.0.jar\",\ \"../../third_party/android_embedding_dependencies/lib/lifecycle-runtime-2.2.0.jar\"\] --bootclasspath=../../third_party/android_tools/sdk/platforms/android-34/android.jar --java-version=1.8 --jar-bin=/b/s/w/ir/cache/builder/src/third_party/java/openjdk/bin/jar --javac-bin=/b/s/w/ir/cache/builder/src/third_party/java/openjdk/bin/javac ../../flutter/shell/platform/android/io/flutter/FlutterInjector.java ../../flutter/shell/platform/android/io/flutter/Log.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivity.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivityEvents.java ../../flutter/shell/platform/android/io/flutter/app/FlutterApplication.java ../../flutter/shell/platform/android/io/flutter/app/FlutterFragmentActivity.java ../../flutter/shell/platform/android/io/flutter/app/FlutterPlayStoreSplitApplication.java ../../flutter/shell/platform/android/io/flutter/app/FlutterPluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java ../../flutter/shell/platform/android/io/flutter/embedding/android/ExclusiveAppComponent.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityLaunchConfigs.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterEngineConfigurator.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterEngineProvider.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragment.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterImageView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterPlayStoreSplitApplication.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterSurfaceView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterTextureView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/KeyChannelResponder.java ../../flutter/shell/platform/android/io/flutter/embedding/android/KeyData.java ../../flutter/shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java ../../flutter/shell/platform/android/io/flutter/embedding/android/KeyboardManager.java ../../flutter/shell/platform/android/io/flutter/embedding/android/KeyboardMap.java ../../flutter/shell/platform/android/io/flutter/embedding/android/MotionEventTracker.java ../../flutter/shell/platform/android/io/flutter/embedding/android/RenderMode.java ../../flutter/shell/platform/android/io/flutter/embedding/android/TransparencyMode.java ../../flutter/shell/platform/android/io/flutter/embedding/android/WindowInfoRepositoryCallbackAdapterWrapper.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngineCache.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngineConnectionRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngineGroup.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngineGroupCache.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterOverlaySurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterShellArgs.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartExecutor.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartMessenger.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/PlatformMessageHandler.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/PlatformTaskQueue.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/deferredcomponents/DeferredComponentManager.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/deferredcomponents/PlayStoreDeferredComponentManager.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/ApplicationInfoLoader.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/FlutterApplicationInfo.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/ResourceExtractor.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/mutatorsstack/FlutterMutatorView.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/mutatorsstack/FlutterMutatorsStack.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/FlutterPlugin.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/PluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/lifecycle/HiddenLifecycleReference.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServiceAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServiceControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServicePluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/shim/ShimPluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/shim/ShimRegistrar.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/util/GeneratedPluginRegister.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/FlutterUiDisplayListener.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/RenderSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/SurfaceTextureWrapper.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/DeferredComponentChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyEventChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyboardChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LocalizationChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/MouseCursorChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/NavigationChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/ProcessTextChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/RestorationChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/SettingsChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/SpellCheckChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/SystemChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/TextInputChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/ActivityLifecycleListener.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BasicMessageChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BinaryCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BinaryMessenger.java ../../flutter/shell/platform/android/io/flutter/plugin/common/ErrorLogResult.java ../../flutter/shell/platform/android/io/flutter/plugin/common/EventChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/FlutterException.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONMessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONMethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONUtil.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodCall.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/PluginRegistry.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StandardMessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StandardMethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StringCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/FlutterTextUtils.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/ImeSyncDeferringInsetsCallback.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/ListenableEditingState.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/SpellCheckPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/TextEditingDelta.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/localization/LocalizationPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/mouse/MouseCursorPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/AccessibilityEventsDelegate.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/ImageReaderPlatformViewRenderTarget.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformOverlayView.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformView.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewFactory.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewRegistry.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewRegistryImpl.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewRenderTarget.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsAccessibilityDelegate.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/SingleViewPresentation.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/SurfaceTexturePlatformViewRenderTarget.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/VirtualDisplayController.java ../../flutter/shell/platform/android/io/flutter/plugin/text/ProcessTextPlugin.java ../../flutter/shell/platform/android/io/flutter/util/HandlerCompat.java ../../flutter/shell/platform/android/io/flutter/util/PathUtils.java ../../flutter/shell/platform/android/io/flutter/util/Preconditions.java ../../flutter/shell/platform/android/io/flutter/util/Predicate.java ../../flutter/shell/platform/android/io/flutter/util/TraceSection.java ../../flutter/shell/platform/android/io/flutter/util/ViewUtils.java ../../flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java ../../flutter/shell/platform/android/io/flutter/view/AccessibilityViewEmbedder.java ../../flutter/shell/platform/android/io/flutter/view/FlutterCallbackInformation.java ../../flutter/shell/platform/android/io/flutter/view/FlutterMain.java ../../flutter/shell/platform/android/io/flutter/view/FlutterNativeView.java ../../flutter/shell/platform/android/io/flutter/view/FlutterRunArguments.java ../../flutter/shell/platform/android/io/flutter/view/FlutterView.java ../../flutter/shell/platform/android/io/flutter/view/TextureRegistry.java ../../flutter/shell/platform/android/io/flutter/view/VsyncWaiter.java gen/flutter/shell/platform/android/io/flutter/BuildConfig.java
Traceback (most recent call last):
File "../../build/android/gyp/javac.py", line 23, in <module>
import coloramaClosing, I'll send a PR moving it instead. |
Member
|
It looks like |
matanlurey
added a commit
to flutter/buildroot
that referenced
this pull request
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of eliminating the Flutter buildroot (flutter/flutter#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. Fortunately, this package appears unused, so we can just delete it!