This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename font-subset to font_subset.#49051
Merged
matanlurey merged 2 commits intoflutter:mainfrom Dec 14, 2023
Merged
Conversation
jason-simmons
approved these changes
Dec 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
flutter/engine@0e7248d...4cb3ba7 2023-12-15 [email protected] Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069) 2023-12-15 [email protected] Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065) 2023-12-15 [email protected] [Impeller] impellerc: delete unused code (flutter/engine#49061) 2023-12-15 [email protected] [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050) 2023-12-15 [email protected] Revert "[Impeller] Turned on new blur." (flutter/engine#49062) 2023-12-14 [email protected] Fix header-guard naming convention in `shell/`. (flutter/engine#49006) 2023-12-14 [email protected] Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054) 2023-12-14 [email protected] Rename `font-subset` to `font_subset`. (flutter/engine#49051) 2023-12-14 [email protected] Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056) 2023-12-14 [email protected] Suppress warning for the new Activity library. (flutter/engine#49046) 2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency, I don't think we have any other tools with
-'s.I'll be honest - this seemed easier than teaching the header guard tool how to handle
-'s in directory names, but if you feel strongly about it I can revert.