This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
Changes since last roll ``` e8cdc554c59 (tag: 3.3.0-242.0.dev, origin/dev) Version 3.3.0-242.0.dev a5109dc82ba [build] Handle RBE in -fdebug-prefix-map. 2ff976e9e3a [infra] Specify Linux in RBE platform. 12c548d331b [macros] Add first language tests for introspection. 3eeba4a4e2a [cfe] Refactor FunctionNode.futureValueType into emitted value type 8d8c4c61250 [cfe] Handle extension types in *Concatenation nodes f49c7864436 [cfe/analyzer] Report error on invalid abstract final class modifier combinations 338fd6501b6 [dart2wasm] Make _RecordType use WasmArray<>s instead of List<>s 355d7e02fcf (origin/base) Stop testing nnbd-weak and nnbd-legacy on analyzer. 27892de3497 Adding DTD and DTD_impl owners. 6a9216a46fc Remove Requirements=nnbd-weak from superinterfaces_out_of_order_error_test.dart. d646c92abe6 Macro. Tests for StaticType.isSubtype() 5881d669f0a Update DevTools rev to c7aa1df42178b054901c36bb1b8ea25b5542be8c 63594497660 Remove dead code in prefer_constructors_over_static_methods.dart 739baa4bc10 Macro. Implement DefinitionPhaseIntrospector.inferType() 794d3adf93d [VM] - Minor cleanups 3e73f10de09 Disable fixes for unawaited_futures in cascades. 8348807c860 stop collecting `strictCasts` settings from options 38e2d34424e [ddc] Erase extension types in as expressions 8d24f7ebd41 [ddc] Erase extension types in string concats b2cd914227b [ddc] Erase extension types in assertions 66a955b09f1 Fixed typo 48ac398f112 Fix `Directory.current` setter compatibility with `IOOverrides` c84edaefe9e Check in //third_party/root_certificates. 63f5b1272b1 Discover actual dart-sdk/ and bin/ when running tools/test.py 81dc3f6f6e7 [tests/ffi]: Fix failing pointer arithmetic test. 83ba9fe0a8d [ddc] Enable new runtime types by default 95e049c7e28 Add a test case for flutter#52233 3e2ac6721d5 [linter] Report deprecated_consistency only on constructor name 89381ea4dbe [linter] Simplify 'prefer_mixin' implementation ```
zanderso
approved these changes
Dec 19, 2023
aam
force-pushed
the
roll-dart-20231219
branch
from
21cb127 to
5a3d080
Compare
aam
changed the title
Member
Author
|
@zanderso PTAL at license-related changes |
zanderso
approved these changes
Dec 19, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
still lgtm if the license check is still happy.
| '/third_party/libcxx/LICENSE.TXT': _RepositoryCxxStlDualLicenseFile.new, | ||
| '/third_party/libcxxabi/LICENSE.TXT': _RepositoryCxxStlDualLicenseFile.new, | ||
| '/third_party/libpng/LICENSE': _RepositoryLibPngLicenseFile.new, | ||
| '/third_party/root_certificates/LICENSE': _RepositoryMpl2File.new, |
Member
There was a problem hiding this comment.
Wondering if this will need to be updated to the new path rather than removed, but if the license script is still happy this lgtm.
Member
Author
There was a problem hiding this comment.
Yeah, the script seems to be happy without this.
Contributor
|
auto label is removed for flutter/engine/49239, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2023
flutter/engine@3b156c8...df1593e 2023-12-19 [email protected] Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248) 2023-12-19 [email protected] Roll dart to 3.3.0-242.0.dev (flutter/engine#49239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…0422) flutter/engine@3b156c8...df1593e 2023-12-19 [email protected] Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248) 2023-12-19 [email protected] Roll dart to 3.3.0-242.0.dev (flutter/engine#49239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes since last roll
This PR also includes changes to license script to accommodate new location for
root_certificatessources.