This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add armv7 support to create_ios_framework script#4942
Merged
cbracken merged 1 commit intoflutter:masterfrom Apr 5, 2018
cbracken:update-lipo-script
Merged
Add armv7 support to create_ios_framework script#4942cbracken merged 1 commit intoflutter:masterfrom cbracken:update-lipo-script
cbracken merged 1 commit intoflutter:masterfrom
cbracken:update-lipo-script
Conversation
This adds support for --armv7-out-dir and renames --device-out-dir to --arm64-out-dir for clarity. It preserves --device-out-dir as a fallback until the bot recipe has been updated to use --arm64-out-dir.
Member
Author
|
One in a series of many changes related to flutter/flutter#2089 |
chinmaygarde
approved these changes
Apr 5, 2018
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
You could also just land both the changes in one shot and break a single build on the bots. Your call.
Member
Author
|
SGTM. Will fire it off in two changes just in case anything goes wrong with the bot recipe update and I need to roll back. |
This was referenced Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for --armv7-out-dir and renames --device-out-dir to
--arm64-out-dir for clarity. It preserves --device-out-dir as a fallback
until the bot recipe has been updated to use --arm64-out-dir.