Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] add doc on iOS flamegraph capture.#49469

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
jonahwilliams:disable_capture_non_capture
Jan 2, 2024
Merged

[Impeller] add doc on iOS flamegraph capture.#49469
auto-submit[bot] merged 3 commits intoflutter:mainfrom
jonahwilliams:disable_capture_non_capture

Conversation

@jonahwilliams
Copy link
Contributor

I find flamegraphs pretty useful, but Xcode doesn't have one built in that I know of.

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


![Alt text](assets/ios_profiling/ios_profiler_select_thread.png)

4. Either via keyboard short cut or edit menu, "Deep Copy" the trace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Either via keyboard short cut or edit menu, "Deep Copy" the trace.
4. Copy the trace with the keyboard shortcut or the menu ("Edit" -> "Deep Copy").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we mention the keyboard shortcut we should mention what it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@auto-submit auto-submit bot merged commit 3a7aa01 into flutter:main Jan 2, 2024
@jonahwilliams jonahwilliams deleted the disable_capture_non_capture branch January 2, 2024 23:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 3, 2024
flutter/engine@e95e123...3a7aa01

2024-01-02 [email protected] [Impeller] add doc on iOS flamegraph capture. (flutter/engine#49469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants