This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Refactor logic when window resize completes#49872
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Jan 18, 2024
Merged
[Windows] Refactor logic when window resize completes#49872auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
loic-sharma
changed the title
| } | ||
|
|
||
| EGLBoolean AngleSurfaceManager::SwapBuffers() { | ||
| bool AngleSurfaceManager::SwapBuffers() { |
Contributor
There was a problem hiding this comment.
What is the purpose of this change?
Member
There was a problem hiding this comment.
Anytime we can avoid leaking implementation details (including types) from behind interfaces, it's a nice plus. Users of our surface managers shouldn't need to know about the underlying usage of GL types.
Comment on lines
+157
to
+162
| if (!engine_->surface_manager()->SwapBuffers()) { | ||
| return false; | ||
| } | ||
|
|
||
| engine_->view()->OnFramePresented(); | ||
| return true; |
Contributor
There was a problem hiding this comment.
Should this be refactored into a separate function? It looks like this and the below addition to this file are identical.
Member
Author
There was a problem hiding this comment.
You are right that they're identical, but I think the logic is short enough that it's okay to repeat. I don't feel super strongly about this though, let me know if you do and I'd be happy to update this.
Contributor
There was a problem hiding this comment.
Just a thought. I don't think it's too important either way.
yaakovschectman
approved these changes
Jan 18, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
flutter/engine@9dded18...dde3ebf 2024-01-18 [email protected] [Windows] Refactor logic when window resize completes (flutter/engine#49872) 2024-01-18 [email protected] Roll Skia from 40200ceca00e to da3bfb25fb84 (1 revision) (flutter/engine#49873) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
loic-sharma
added
the
revert
Contributor
|
Time to revert pull request flutter/engine/49872 has elapsed. |
auto-submit
bot
removed
the
revert
This was referenced Jan 22, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
#49872 introduced a crash in debug mode if the platform thread starts a window resize in between `OnFrameGenerated` and `OnFramePresented`. Fixes flutter/flutter#141855. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
FlutterWindowsViewtoCompositorOpenGLFlutterWindowsView::SwapBufferstoFlutterWindowsView::OnFramePresentedPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.