Supports building with RBE on a Windows host.#49877
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
zanderso
force-pushed
the
try-win-rbe
branch
4 times, most recently
from
eab4d41 to
849336d
Compare
zanderso
force-pushed
the
try-win-rbe
branch
2 times, most recently
from
8cee961 to
28e1eff
Compare
zanderso
changed the title
| 'version': Var('reclient_version'), | ||
| } | ||
| ], | ||
| 'condition': 'use_rbe and download_windows_deps', |
There was a problem hiding this comment.
Do you need host_cpu == "x64"?
There was a problem hiding this comment.
We don't currently do that anywhere else for Windows dependencies, so I'll follow suit in this PR.
flutter/engine@1232d59...8c521eb 2024-02-09 [email protected] Roll Skia from fbe1d2265637 to 4081496b7693 (1 revision) (flutter/engine#50499) 2024-02-09 [email protected] Supports building with RBE on a Windows host. (flutter/engine#49877) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Requires flutter/buildroot#820