This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Mac cache_builder back into Prod#49936
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Jan 22, 2024
Merged
Conversation
zanderso
approved these changes
Jan 22, 2024
ricardoamador
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 22, 2024
flutter/engine@d653559...b2762f4 2024-01-22 [email protected] Add Mac cache_builder back into Prod (flutter/engine#49936) 2024-01-22 [email protected] Roll Skia from cc042f38288e to be066a6524ab (2 revisions) (flutter/engine#49937) 2024-01-22 [email protected] [Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#49838) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
This reverts commit b2762f4.
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jan 23, 2024
Reverts #49936 Initiated by: zanderso This change reverts the following previous change: Original Description: Add the Mac cache_builder target back to prod. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#141688 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Mac cache_builder target back to prod.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#141688
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.