Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Exclude prebuilts/Library from Mac builder_cache#49971

Merged
auto-submit[bot] merged 1 commit intomainfrom
zanderso-patch-6
Jan 23, 2024
Merged

Exclude prebuilts/Library from Mac builder_cache#49971
auto-submit[bot] merged 1 commit intomainfrom
zanderso-patch-6

Conversation

@zanderso
Copy link
Member

Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor

IIUC, with this PR, recipes will refresh CAS (which is shared across staging, prod and try - we may want to distinguish them in the future) with correct info. Then from builds side, they just pull whatever is in CAS to path['cache'].join('builder').

Let's land this PR first to allow path['cache'].join('builder') to have the correct info.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2024
@auto-submit auto-submit bot merged commit affd675 into main Jan 23, 2024
@auto-submit auto-submit bot deleted the zanderso-patch-6 branch January 23, 2024 18:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
flutter/engine@9940541...57d6b51

2024-01-23 [email protected] [Impeller] fix validation error for playground texture upload. (flutter/engine#49957)
2024-01-23 [email protected] [Impeller] Fix runtime effect pipeline depth/stencil. (flutter/engine#49953)
2024-01-23 [email protected] Exclude prebuilts/Library from Mac builder_cache (flutter/engine#49971)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants