This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix iOS password autofill prompt dismissal causes layout to resize#50364
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Feb 5, 2024
TahaTesser:fix_iOS_password_prompt_bug
Merged
Fix iOS password autofill prompt dismissal causes layout to resize#50364auto-submit[bot] merged 1 commit intoflutter:mainfrom TahaTesser:fix_iOS_password_prompt_bug
auto-submit[bot] merged 1 commit intoflutter:mainfrom
TahaTesser:fix_iOS_password_prompt_bug
Conversation
justinmc
approved these changes
Feb 5, 2024
shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm
Outdated
Show resolved
Hide resolved
|
|
||
| // Avoid triggering startKeyBoardAnimation when keyboard notifications are triggered | ||
| // by the dismissal of password autofill prompt. When this happens, there is | ||
| // no keyboard on the screen and FlutterTextInputViewAccessibilityHider is nil. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 6, 2024
flutter/engine@9bd98bc...9c1b6c9 2024-02-05 [email protected] Manual roll Dart SDK from 5a5d4c262200 to b62066b42af0 (5 revisions) (flutter/engine#50366) 2024-02-05 [email protected] Fix iOS password autofill prompt dismissal causes layout to resize (flutter/engine#50364) 2024-02-05 [email protected] `visiblePassword` uses ASCII keyboard on iOS (flutter/engine#50293) 2024-02-05 [email protected] [Impeller] Do not reference `this` in the submit callback for Metal GPU Surfaces (flutter/engine#50361) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
Author
|
Reverting this since this is causing a regression for text field created by a third-party package. |
Contributor
|
Time to revert pull request flutter/engine/50364 has elapsed. |
8 tasks
Contributor
Author
|
Reverting this manually in #50760 |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
…esize (#50364)" (#50760) This reverts commit 472df41. Reverts #50364 fixes flutter/flutter#143642 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Save password prompt dismiss is pushing UI up and down
Code sample
expand to view the code sample
Before
RPReplay_Final1707164728.mov
After
RPReplay_Final1707164662.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.