[Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism#50506
[Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism#50506gaaclarke merged 2 commits intoflutter:mainfrom
Conversation
|
You could probably improve this even further by removing the functions pointers now that things are templated. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Should be test exempt as its a refactor/non-semantic change that is already tested
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter/engine@8c521eb...6a3b021 2024-02-09 [email protected] [Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism (flutter/engine#50506) 2024-02-09 [email protected] [web] Fix HtmlViewEmbedder.dispose (flutter/engine#50482) 2024-02-09 [email protected] Roll Dart SDK from 03130d49f214 to 444f7a422da4 (6 revisions) (flutter/engine#50502) 2024-02-09 [email protected] [Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage. (flutter/engine#50379) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
followup to #50379
improvements:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.