Make .style.yapf and .pylintrc agree on line length#50510
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Ha. The |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Appreciate the quick fix. This wasn't blocking, just a minor annoyance.
|
test-exempt: config file changes |
flutter/engine@6a3b021...f969c52 2024-02-09 [email protected] [Impeller] Remove the unused Vulkan queue submit task runner (flutter/engine#50511) 2024-02-09 [email protected] Make .style.yapf and .pylintrc agree on line length (flutter/engine#50510) 2024-02-09 [email protected] [Impeller] Call vkQueuePresentKHR through the ContextVK's synchronized graphics queue wrapper (flutter/engine#50509) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
For flutter/flutter#143243
yapf and pylint check different things, but occasionally overlap. I think we'll just have to make them agree when we catch them fighting.