This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement the render_to_surface flag in GPUSurfaceGLImpeller#50669
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Feb 20, 2024
Merged
Implement the render_to_surface flag in GPUSurfaceGLImpeller#50669auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Without this, the EmbedderExternalViewEmbedder's call to SurfaceFrame::Submit will render an empty display list that will overwrite the output rendered by the external view embedder's layers. See flutter/flutter#143387
jonahwilliams
approved these changes
Feb 15, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
I mean if it works it works, so RSLGTM
But I'm not really sure what the intention of this flag is, or if we need to handle it being false too? FYI @cbracken
chinmaygarde
approved these changes
Feb 15, 2024
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
cbracken
approved these changes
Feb 20, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2024
flutter/engine@2782805...1ae2c10 2024-02-20 [email protected] Move the `scenario_app` running Impeller+OpenGLES to `bringup: triue` (flutter/engine#50789) 2024-02-20 [email protected] Implement the render_to_surface flag in GPUSurfaceGLImpeller (flutter/engine#50669) 2024-02-20 [email protected] [et] Adds a .bat entrypoint for Windows (flutter/engine#50784) 2024-02-20 6844906[email protected] [Fuchsia] Create dedicated testers to run tests and deprecate femu_test (flutter/engine#50697) 2024-02-20 [email protected] Roll Skia from 50e1b709781c to 9d86359b5fe8 (2 revisions) (flutter/engine#50786) 2024-02-20 [email protected] Roll Skia from 2dc00a705f1c to 50e1b709781c (5 revisions) (flutter/engine#50785) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, the EmbedderExternalViewEmbedder's call to SurfaceFrame::Submit will render an empty display list that will overwrite the output rendered by the external view embedder's layers.
See flutter/flutter#143387