This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add xcode-symlinks to mac_clang_tidy configs#51057
Closed
Conversation
To fix slow RBE build times.
gaaclarke
approved these changes
Feb 28, 2024
zanderso
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/51057, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Member
Author
|
This is failing the mac clang-tidy presubmit check because the subshards for testing don't have the symlinks created that the xcode-symlinks flag creates, which are referenced in the clang/clang-tidy commands. I'm going to close this, and back out RBE on this builder until I figure out a solution for that. |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Reverting for build time regression: #51057 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix slow RBE build times.