[et] Allow users to update dependencies#51177
Conversation
| Run tests using `//flutter/testing/run_tests.py`: | ||
|
|
||
| ```shell | ||
| testing/run_tests.py --type dart-host --dart-host-filter flutter/tools/engine_tool |
There was a problem hiding this comment.
This depends on your OS. On Windows this should be --dart-host-filter flutter\tools\engine_tool 😞
There was a problem hiding this comment.
We could add a script or scripts under engine_tool/dev that runs the tests? (Eventually maybe we'll add et build //flutter/tools/engien_tool:run_tests or something.)
There was a problem hiding this comment.
Personally I'm fine with using run_tests.py in the short-term with a pointer on how to do so. I'll defer to whatever y'all think is best for now though :)
There was a problem hiding this comment.
Nothing needed about this for this PR. Just jotting down the idea.
| Run tests using `//flutter/testing/run_tests.py`: | ||
|
|
||
| ```shell | ||
| testing/run_tests.py --type dart-host --dart-host-filter flutter/tools/engine_tool |
There was a problem hiding this comment.
We could add a script or scripts under engine_tool/dev that runs the tests? (Eventually maybe we'll add et build //flutter/tools/engien_tool:run_tests or something.)
|
|
||
| final Map<String, BuilderConfig> configs = <String, BuilderConfig>{}; | ||
|
|
||
| (Environment, List<List<String>>) linuxEnv(Logger logger) { |
There was a problem hiding this comment.
Instead of copying this into the test, I'd consider (does not have to be in this PR) moving this to like test/envrionment.dart. It might also make sense to encapsulate the concept of runHistory versus over-using primitives (see, for example FakeAdbLogcat).
loic-sharma
force-pushed
the
et_fetch
branch
3 times, most recently
from
ac5eb8d to
d682b82
Compare
loic-sharma
dismissed
johnmccutchan’s stale review
Addressed feedback; ready for re-review
loic-sharma
added
the
autosubmit
flutter/engine@b6efe0d...9aad0e9 2024-03-06 [email protected] [et] Allow users to update dependencies (flutter/engine#51177) 2024-03-06 [email protected] Manual roll Dart SDK from 728fcf0bcbca to 50464546d92d (5 revisions) (flutter/engine#51228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Allow users to update dependencies. Examples:
et fetchFetch dependenciesIn the future,
et buildwill update dependencies if it detects that they have changed.Also:
et run's description--verboseflag global