This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fold memory check into allocator_vk#51187
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom Mar 6, 2024
Merged
[Impeller] fold memory check into allocator_vk#51187auto-submit[bot] merged 7 commits intoflutter:mainfrom
auto-submit[bot] merged 7 commits intoflutter:mainfrom
Conversation
added 3 commits
March 4, 2024 16:44
matanlurey
approved these changes
Mar 6, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
It was a little tough to review 5 changes at once, especially as I'm not super familiar. If these changes aren't interconnected I'd recommend splitting them up somewhat, if they are then I suppose it's fine 😅
| // Query texture support. | ||
| // TODO(jonahwilliams): | ||
| // https://github.com/flutter/flutter/issues/129784 | ||
| physical_device.getMemoryProperties(&memory_properties_); |
Contributor
There was a problem hiding this comment.
Wasn't this already done above on line 182? Or is the scope significant somehow?
Contributor
Author
There was a problem hiding this comment.
oh good call. Will fix
| for (auto i = 0u; i < memory_properties_.memoryTypeCount; i++) { | ||
| if (memory_properties_.memoryTypes[i].propertyFlags & | ||
| vk::MemoryPropertyFlagBits::eLazilyAllocated) { | ||
| supports_memoryless_textures_ = true; |
Contributor
There was a problem hiding this comment.
break after since it doesn't seem relevant to iterate through once we find one?
jonahwilliams
force-pushed
the
track_allocations
branch
from
046b052 to
99c9ce7
Compare
jonahwilliams
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
Framework side to flutter/engine#51187 Part of #144617
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
flutter/engine@44405ae...5bbac1a 2024-03-06 [email protected] [Impeller] fold memory check into allocator_vk (flutter/engine#51187) 2024-03-06 [email protected] Roll Fuchsia Linux SDK from ujOkbeYbrC8loPbfR... to y67DIBX84h7pAekIp... (flutter/engine#51233) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ujOkbeYbrC8l to y67DIBX84h7p If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
Author
jonahwilliams
added
the
revert
Contributor
|
A reason for requesting a revert of flutter/engine/51187 could |
auto-submit
bot
removed
the
revert
Contributor
Author
jonahwilliams
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
This reverts commit 5bbac1a.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Mar 6, 2024
…1243) Reverts: #51187 Initiated by: jonahwilliams Reason for reverting: unexpected benchmark regression https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396 Original PR Author: jonahwilliams Reviewed By: {matanlurey} This change reverts the following previous change: Various cleanups to Vulkan allocator implementation: 1. Fixes flutter/flutter#137454 2. Fold device transient cap check into allocator. 3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through) 4. Small cleanups to mock vulkan so an allocator can be created from it. 5. depth/stencil shouldn't be input attachments. Part of flutter/flutter#144617
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
) Part of flutter/flutter#144617 Adds MemoryBudgetUsageMB which includes the MB of VMA allocated GPU and host memory, approximately per frame. This will be recorded in the devicelab and used to track how much memory pressure we're creating. Split out from #51187 since that was reverted (and doing big changes is a bad idea anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cleanups to Vulkan allocator implementation:
Part of flutter/flutter#144617