Disambiguate conditional expressions#51285
Conversation
|
Chinmay, can you take a look if this is right? |
|
This is a bit of a head scratcher. I could not get the error to reproduce on our build even after setting This seems like a bug. But I am honestly not sure. Your patch seems fine to me to unblock the roll and we should land it. But I don't think we have a way of avoiding this same issue in the future. Can you file a separate issue for 32 bit platforms please? Otherwise LGTM on this patch. Thanks! |
|
Thanks! I was quite confused as well - here's my understanding of the issue. These ternary expressions in this PR fails to build when targeting 32-bit platforms, when the I have filed flutter/flutter#144916 to track this :) |
flutter/engine@d13999c...210f84e 2024-03-11 [email protected] Disambiguate conditional expressions (flutter/engine#51285) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Internally, when targeting x86 Android, these files fail to compile:
The cause is that internally,
VULKAN_HPP_TYPESAFE_CONVERSIONis set but not for the GN build here. Copying from the vulkan docs:I'm not sure if doing the
static_caston theVK_NULL_HANDLEin this PR is right though. When targeting x86, this macro ends up being defined as0LL. But at the same time, putting the cast on the other ternary branch (e.g.static_cast<vk::Sampler>(immutable_sampler->GetSampler())) doesn't resolve the error.List which issues are fixed by this PR. You must list at least one issue.
b/328355475
Pre-launch Checklist
///).