This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove --enable-impeller-{backend} flags (always True).#51402
Merged
matanlurey merged 5 commits intoflutter:mainfrom Mar 14, 2024
Merged
Remove --enable-impeller-{backend} flags (always True).#51402matanlurey merged 5 commits intoflutter:mainfrom
--enable-impeller-{backend} flags (always True).#51402matanlurey merged 5 commits intoflutter:mainfrom
Conversation
Contributor
|
Something seems up with CI |
Contributor
Author
|
I guess I broke the YAML format. Will fix it tomorrow 🙂 |
Contributor
Author
Or not, it was easy |
matanlurey
changed the title
--enable-impeller-{backend} flags that default to True.--enable-impeller-{backend} flags (always True).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2024
flutter/engine@bdf66af...1da1597 2024-03-14 [email protected] Remove `--enable-impeller-{backend}` flags (always `True`). (flutter/engine#51402) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#142725.