This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add details to renderdoc_frame_capture.md#51483
Merged
auto-submit[bot] merged 2 commits intomainfrom Mar 18, 2024
Merged
Conversation
I still haven't figured out how to make this work, but here's some additional details that I did figure out!
chinmaygarde
approved these changes
Mar 18, 2024
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I don't think I've ever had to build renderdoc from source. Which environment are you running on?
loic-sharma
reviewed
Mar 18, 2024
| Building a "debug_unopt" build ensures that you have tracing enabled. Without this, RenderDoc will not have much to show. | ||
|
|
||
| 3. Start RenderDoc, and click the "Launch Application" button. | ||
| 3. Start RenderDoc using the `qrenderdoc` command, and (if necessary) select "Launch Application" button from the menu: |
Member
There was a problem hiding this comment.
On Windows this is a normal GUI application that isn't launched from the command line. Should we split this into two steps?
Something like:
Suggested change
| 3. Start RenderDoc using the `qrenderdoc` command, and (if necessary) select "Launch Application" button from the menu: | |
| 3. Start RenderDoc. On Linux, use the `qrenderdoc` command | |
| 4. If necessary, select "Launch Application" button .... |
Contributor
Author
There was a problem hiding this comment.
I tweaked it a bit for ya. :-)
Contributor
Author
Some variant of Ubuntu. I've no idea why the version from the package manager was crashing on startup, but the version built from source worked fine. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2024
flutter/engine@3fde367...89df726 2024-03-18 [email protected] Add details to renderdoc_frame_capture.md (flutter/engine#51483) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still haven't figured out how to make this work, but here's some additional details that I did figure out!