This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Enables system chrome customization on Android O and greater"#5167
Merged
jonahwilliams merged 2 commits intomasterfrom May 3, 2018
Merged
Revert "Enables system chrome customization on Android O and greater"#5167jonahwilliams merged 2 commits intomasterfrom
jonahwilliams merged 2 commits intomasterfrom
Conversation
added 2 commits
May 3, 2018 15:11
aam
approved these changes
May 3, 2018
Contributor
|
why was this reverted? Should we avoid picking up #5112 without this revert in any engine roll into flutter/flutter? |
Contributor
|
Ah, I see - it looks like it broke the engine builds |
Contributor
Author
|
When I made a last minute change I made a silly typo in the objective C code. I'll fix it and make a new pull request when I am done verifying that I've fixed the driver tests |
sigurdm
pushed a commit
to sigurdm/engine
that referenced
this pull request
May 4, 2018
…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.
sigurdm
pushed a commit
to sigurdm/engine
that referenced
this pull request
May 4, 2018
…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.
sigurdm
pushed a commit
to sigurdm/engine
that referenced
this pull request
May 4, 2018
…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5112