This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delegate AppDelegate life-cycle callbacks to plugins via separate object#5173
Merged
sigurdm merged 3 commits intoflutter:masterfrom May 17, 2018
Merged
Delegate AppDelegate life-cycle callbacks to plugins via separate object#5173sigurdm merged 3 commits intoflutter:masterfrom
sigurdm merged 3 commits intoflutter:masterfrom
Conversation
…pDelegate. Also moves the plugin registry to FlutterViewController. So each view-controller will handle its own plugins. This is intended to simplify including one or more Flutter views in an existing iOS app and giving more precise control of plugin registration. Fixes: flutter/flutter#16539
Contributor
Author
|
@chinmaygarde do you like the direction this goes? |
Member
|
This has broken mac engine buildbot https://build.chromium.org/p/client.flutter/builders/Mac%20Engine/builds/2861/steps/build%20ios_debug_arm/logs/stdio: |
aam
added a commit
to aam/engine
that referenced
this pull request
May 17, 2018
…rate object (flutter#5173)" This reverts commit 597fa9e as it broke flutter engine mac build bot.
aam
added a commit
to aam/engine
that referenced
this pull request
May 17, 2018
…rate object (flutter#5173)" This reverts commit 597fa9e as it broke mac engine build bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moves the plugin registry to FlutterViewController. So each view-controller will handle its
own plugins.
This is intended to simplify including one or more Flutter views in an existing iOS app and giving
more precise control of plugin registration.
Fixes: flutter/flutter#16539