This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the rasterizer's compositor context and texture registry to capture screenshots#5180
Merged
jason-simmons merged 1 commit intoflutter:masterfrom May 4, 2018
Merged
Conversation
Member
Author
chinmaygarde
approved these changes
May 4, 2018
Contributor
|
This has been identified as causing a regression in screenshotting that is currently blocking Flutter dev releases. Here's a snippet from the Flutter gallery:
|
Member
Author
|
I suspect this is happening because the main compositor context's raster cache is now being used to render screenshots. Using the same raster cache that is used to render to the display will yield screenshots that more accurately reflect the display, but at the risk of fuzzier output. |
Contributor
|
Tracking in flutter/flutter#17448 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#16412