Move libcxx to //flutter/third_party#52773
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is green, and there's another buildroot change that I need to rebase on this to test it, so I'll go ahead and land this one. |
flutter/engine@bee398d...84687fe 2024-05-14 [email protected] Replace `json_utils` with a modern `extension type`, add tests. (flutter/engine#52769) 2024-05-14 [email protected] Move libcxx to //flutter/third_party (flutter/engine#52773) 2024-05-14 [email protected] [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator (flutter/engine#52708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Fixes flutter/flutter#144202