This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Filter out bad locales returned by g_get_language_names#55091
Merged
robert-ancell merged 2 commits intoflutter:mainfrom Sep 12, 2024
Merged
Filter out bad locales returned by g_get_language_names#55091robert-ancell merged 2 commits intoflutter:mainfrom
robert-ancell merged 2 commits intoflutter:mainfrom
Conversation
Contributor
Author
|
@hbatagelo you might also be interested in reviewing. |
hbatagelo
reviewed
Sep 11, 2024
Contributor
hbatagelo
left a comment
hbatagelo
left a comment
There was a problem hiding this comment.
LGTM. Just a minor nit for consistency.
Co-authored-by: Harlen Batagelo <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 13, 2024
flutter/engine@4d5fea9...3d8163f 2024-09-12 [email protected] Filter out bad locales returned by g_get_language_names (flutter/engine#55091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing issues with and "und" (undefined) locale and exceptions in applications (see ubuntu/app-center#1659). It seems the GLib method for getting the language names doesn't clean up invalid values, so we should do that.