Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove now unused extra args/opts/env from run_tests.py.#55164

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
matanlurey:remove-extra-args
Sep 13, 2024
Merged

Remove now unused extra args/opts/env from run_tests.py.#55164
auto-submit[bot] merged 3 commits intoflutter:mainfrom
matanlurey:remove-extra-args

Conversation

@matanlurey
Copy link
Contributor

As a result of flutter/flutter#133569, Dart tests all use the standard dart test runner or engine_repo_tools to find paths.

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2024
@auto-submit auto-submit bot merged commit 04802b7 into flutter:main Sep 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2024
flutter/engine@3d8163f...04802b7

2024-09-13 [email protected] Remove now unused extra args/opts/env from `run_tests.py`. (flutter/engine#55164)
2024-09-13 [email protected] Remove `assert(() {... })` and other unnecessary patterns in `dart:ui` tests (flutter/engine#55165)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants