Added .vscode back to being ignored#55195
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
flutter/engine@362b9bc...6b69813 2024-09-16 [email protected] Roll Skia from ee5e413fe436 to 87ba10cbfad3 (5 revisions) (flutter/engine#55233) 2024-09-16 [email protected] Roll Skia from 3ebf0a14bbdd to ee5e413fe436 (1 revision) (flutter/engine#55229) 2024-09-16 [email protected] Added .vscode back to being ignored (flutter/engine#55195) 2024-09-16 [email protected] Roll Skia from 80583104076d to 3ebf0a14bbdd (1 revision) (flutter/engine#55228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
#53974 stopped ignoring the .vscode directory, this created a situation where people's vscode settings are prone to getting checked in or nuked. I added a specific exception for the one file we did check in.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.