This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] merge aiks directory into impeller/display_list directory.#55471
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom Oct 2, 2024
Merged
[impeller] merge aiks directory into impeller/display_list directory.#55471auto-submit[bot] merged 5 commits intoflutter:mainfrom
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
jonahwilliams
changed the title
chinmaygarde
approved these changes
Sep 30, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2024
flutter/engine@3bdc1c0...751ab9b 2024-10-02 [email protected] Check stability against most recent cipd emulator artifact (flutter/engine#55591) 2024-10-02 [email protected] Roll Skia from ce27189cef4b to 61bb59fcef34 (2 revisions) (flutter/engine#55588) 2024-10-02 [email protected] [impeller] merge aiks directory into impeller/display_list directory. (flutter/engine#55471) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
…flutter/engine#55471) Aiks has been gutted, and most of the reming types need to be merged with dl/entity types and deleted. this is difficult to do with impeller/display_list and aiks as separate gn targets as it requires circular deps. Lets merge them and remove the aiks directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiks has been gutted, and most of the reming types need to be merged with dl/entity types and deleted. this is difficult to do with impeller/display_list and aiks as separate gn targets as it requires circular deps.
Lets merge them and remove the aiks directory.