Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

DO NOT MERGE: Let's find out if NDEBUG is defined in ios_debug_sim builds#55626

Closed
cbracken wants to merge 2 commits intoflutter:mainfrom
cbracken:what-is-going-on-on-ci
Closed

DO NOT MERGE: Let's find out if NDEBUG is defined in ios_debug_sim builds#55626
cbracken wants to merge 2 commits intoflutter:mainfrom
cbracken:what-is-going-on-on-ci

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Oct 3, 2024 •
edited
Loading

Do not LGTM. Do not merge.

For context, see: #55621

Issue: flutter/flutter#156166

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Copy link
Member Author

cbracken commented Oct 3, 2024

@jmagman let's see what happens.

@cbracken
Copy link
Member Author

cbracken commented Oct 3, 2024 •
edited
Loading

For ios_debug_sim_unopt:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/1210053/overview

Test Suite 'IOSSurfaceNoopTest' started at 2024-10-03 12:06:10.179.
Test Case '-[IOSSurfaceNoopTest testCreateSurface]' started.
2024-10-03 12:06:10.183176-0700 IosUnitTests[19489:122395] ============================= NDEBUG is defined
Test Case '-[IOSSurfaceNoopTest testCreateSurface]' passed (0.007 seconds).
Test Suite 'IOSSurfaceNoopTest' passed at 2024-10-03 12:06:10.192.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.007 (0.014) seconds

For iOS_debug_sim_unopt_arm64:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/1210055/overview

Test Suite 'IOSSurfaceNoopTest' started at 2024-10-03 12:02:01.021.
Test Case '-[IOSSurfaceNoopTest testCreateSurface]' started.
2024-10-03 12:02:01.023299-0700 IosUnitTests[12579:84991] ============================= NDEBUG is defined
Test Case '-[IOSSurfaceNoopTest testCreateSurface]' passed (0.003 seconds).
Test Suite 'IOSSurfaceNoopTest' passed at 2024-10-03 12:02:01.026.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.003 (0.005) seconds

Well that's interesting. You know... in a bad way.

@cbracken cbracken mentioned this pull request Oct 3, 2024
Closed
@jmagman
Copy link
Member

jmagman commented Oct 3, 2024 

2024-10-03 13:00:54.001709-0700 IosUnitTests[56905:353895] ============================= NDEBUG is defined
2024-10-03 13:00:54.001862-0700 IosUnitTests[56905:353895] ============================= DEBUG is NOT defined

@chinmaygarde
Copy link
Contributor

chinmaygarde commented Oct 7, 2024

The NDEBUG macros are set here. Perhaps its easier to tell by using gn desc instead.

@chinmaygarde
Copy link
Contributor

chinmaygarde commented Oct 14, 2024

May I close this?

@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Oct 14, 2024
@cbracken cbracken closed this Oct 14, 2024
@cbracken
Copy link
Member Author

cbracken commented Oct 14, 2024

Closed -- sorry about that! Should have closed it right away.

@cbracken cbracken deleted the what-is-going-on-on-ci branch October 30, 2024 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-ios Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @jmagman @chinmaygarde