This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support all keyboard actions. (#11344)#5620
Merged
matthew-carroll merged 4 commits intoflutter:masterfrom Jul 2, 2018
Merged
Conversation
matthew-carroll
requested review from
Hixie,
cbracken,
chinmaygarde and
gspencergoog
chinmaygarde
approved these changes
Jun 26, 2018
cbracken
approved these changes
Jun 26, 2018
cbracken
reviewed
Jun 26, 2018
| - (BOOL)shouldChangeTextInRange:(UITextRange*)range replacementText:(NSString*)text { | ||
| if (self.returnKeyType == UIReturnKeyDone && [text isEqualToString:@"\n"]) { | ||
| [self resignFirstResponder]; | ||
| [self removeFromSuperview]; |
Member
There was a problem hiding this comment.
Are these not still needed in the done case?
Contributor
Author
There was a problem hiding this comment.
I'm not 100% sure. My experimentation with an actual app didn't show any problem without them, and my assumption is that when the Flutter side says "unfocus" that those same methods are being invoked in some other execution path. But I'm not positive.
Contributor
Author
There was a problem hiding this comment.
FYI - @cbracken and I looked at Japanese and "done" style actions, as well as "next" style actions appear to work as desired with these lines removed.
xster
reviewed
Jun 27, 2018
|
|
||
| static UIReturnKeyType ToUIReturnKeyType(NSString* inputType) { | ||
| if ([inputType isEqualToString:@"TextInputType.multiline"]) | ||
| // Where did the term "unspecified" come from? iOS has a "default" and Android |
Member
There was a problem hiding this comment.
Thanks for the extra context doc!!
Member
|
LGTM |
bkonyi
pushed a commit
that referenced
this pull request
Jul 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support all keyboard actions for iOS and Android. (#11344)
There is a corresponding framework PR:
flutter/flutter#18855