This repository was archived by the owner on Feb 25, 2025. It is now read-only.
remove mock vulkan memory test.#56367
Merged
jonahwilliams merged 1 commit intoflutter:mainfrom Nov 5, 2024
Merged
Conversation
jason-simmons
approved these changes
Nov 5, 2024
Contributor
Author
|
Landing on red to fix tree |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2024
flutter/engine@6271a92...418609d 2024-11-05 [email protected] remove mock vulkan memory test. (flutter/engine#56367) 2024-11-05 [email protected] [web] injectPlatformView into correct flutterView (flutter/engine#56334) 2024-11-05 [email protected] [deps] removed unused deps (dart-lang browser_launcher, clock, bazel_worker, cli_util, csslib, html, json_rpc_2 (flutter/engine#56359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This test is flakey despite using the mocked vulkan backend. This likely indicates that VMA is still performing some real initialization work in a way that is not consistently passing or failing. It may not be safe to use VMA with mock vulkan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flakey despite using the mocked vulkan backend. This likely indicates that VMA is still performing some real initialization work in a way that is not consistently passing or failing.
It may not be safe to use VMA with mock vulkan.