This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Use fml::CFRef in place of Scoped#56463
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Nov 9, 2024
cbracken:cfref-profiler-metrics
Merged
iOS: Use fml::CFRef in place of Scoped#56463auto-submit[bot] merged 4 commits intoflutter:mainfrom cbracken:cfref-profiler-metrics
auto-submit[bot] merged 4 commits intoflutter:mainfrom
cbracken:cfref-profiler-metrics
Conversation
cbracken
requested review from
jmagman,
jonahwilliams,
matanlurey and
stuartmorgan-g
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Added a test. |
`fml::CFRef` implements the bulk of the operations implemented in the one-off `Scoped` class. It doesn't implement the `handle()` method that allows direct writing into the internal storage of the wrapper, but that method is effectively an escape hatch for all the safety guarantees provided by the wrapper, so it seems safer to avoid adding it. Issue: flutter/flutter#137801
stuartmorgan-g
approved these changes
Nov 9, 2024
|
|
||
| // Template specialization used in CFTest.SupportsCustomRetainRelease. | ||
| template <> | ||
| struct CFRefTraits<int64_t> { |
Member
Author
There was a problem hiding this comment.
I'm not proud of what I've done... but I kind of am...
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2024
flutter/engine@2f097cf...ca6f511 2024-11-09 [email protected] iOS: Use fml::CFRef in place of Scoped (flutter/engine#56463) 2024-11-09 [email protected] Roll Dart SDK from 307869c696e8 to ed9a5b1110ae (2 revisions) (flutter/engine#56465) 2024-11-08 [email protected] fml: delete unused scoped_policy (flutter/engine#56462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
Eliminates the use of statics in CFTest.SupportsCustomRetainRelease (introduced in #56463), "clever" as it was. Issue: flutter/flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
`fml::CFRef` implements the bulk of the operations implemented in the one-off `Scoped` class except with better safety guarantees such as `[[nodiscard]]` on the `Release` method. It doesn't implement the `handle()` method that allows direct writing into the internal storage of the wrapper, but that method is effectively an escape hatch for all the safety guarantees provided by the wrapper, so it seems safer to avoid adding it. No changes to tests since this includes no semantic changes. Issue: flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…56480) Eliminates the use of statics in CFTest.SupportsCustomRetainRelease (introduced in flutter/engine#56463), "clever" as it was. Issue: flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fml::CFRefimplements the bulk of the operations implemented in the one-offScopedclass except with better safety guarantees such as[[nodiscard]]on theReleasemethod. It doesn't implement thehandle()method that allows direct writing into the internal storage of the wrapper, but that method is effectively an escape hatch for all the safety guarantees provided by the wrapper, so it seems safer to avoid adding it.No changes to tests since this includes no semantic changes.
Issue: flutter/flutter#137801
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.