This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix: Impeller playground's shapes should react to controllers#56734
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Nov 20, 2024
Merged
Fix: Impeller playground's shapes should react to controllers#56734auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
jonahwilliams
approved these changes
Nov 20, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for fixing this.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2024
flutter/engine@2d32cf3...69c3255 2024-11-20 [email protected] Fix: Impeller playground's shapes should react to controllers (flutter/engine#56734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…r/engine#56734) Fixes flutter#159213 I've went through all `static` in the file and removed the ones that I think are incorrect. <img width="1136" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/29fe63ed-d077-4384-88ec-2f80dcc8c719"> I've experimented with all entity playgrounds to make sure their controllers work, except for `BlendingModeOptions`, which doesn't change whatsoever and I can't figure out. This PR should not need tests, as it fixes the tests. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#159213
I've went through all
staticin the file and removed the ones that I think are incorrect.I've experimented with all entity playgrounds to make sure their controllers work, except for
BlendingModeOptions, which doesn't change whatsoever and I can't figure out.This PR should not need tests, as it fixes the tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.