This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Use eventTarget when computing pointer offset#56949
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Dec 5, 2024
Merged
[web] Use eventTarget when computing pointer offset#56949auto-submit[bot] merged 3 commits intoflutter:mainfrom
eventTarget when computing pointer offset#56949auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
ditman
approved these changes
Dec 4, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Ship it! Thanks for fixing the computeOffset!
| final EditableTextGeometry? inputGeometry = textEditing.strategy.geometry; | ||
| if (inputGeometry != null) { | ||
| return _computeOffsetForInputs(event, inputGeometry); | ||
| return _computeOffsetForInputs(event, eventTarget, inputGeometry); |
Member
There was a problem hiding this comment.
From the docs:
This needs an
eventTarget, because theevent.target(which is what this would really need to use) gets lost when theeventcomes from a "coalesced" event (see: flutter/flutter#155987).
Contributor
Author
There was a problem hiding this comment.
I'll update the docs. The problem I'm seeing in Chrome is actually quite interesting:
The main event has the correct target (input). But the coalesced events have a dummy div as their targets. When I set a breakpoint in Chrome and try to inspect that div, Chrome freezes!
I filed a Chrome bug for it: https://g-issues.chromium.org/issues/382473107
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2024
flutter/engine@b4f52b2...3a8204a 2024-12-05 [email protected] Moved gles pipelines to untracked handles. (flutter/engine#56955) 2024-12-05 [email protected] Roll Dart SDK from a2a9428e761f to 56bbedca60f9 (7 revisions) (flutter/engine#56980) 2024-12-05 [email protected] [web] Use `eventTarget` when computing pointer offset (flutter/engine#56949) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
Dec 17, 2024
These changes are mainly things I missed in flutter#56719 Fixes flutter/flutter#159804
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…#56949) These changes are mainly things I missed in flutter/engine#56719 Fixes flutter#159804
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 8, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
6 tasks
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 8, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 8, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 8, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 9, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck
added a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 9, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
github-merge-queue bot
pushed a commit
to PHS-TSA/nexus
that referenced
this pull request
Jan 9, 2025
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are mainly things I missed in #56719
Fixes flutter/flutter#159804