Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP][3.27][ios]enable the webview non tappable workaround by checking subviews recursively #57168#57172

Merged
auto-submit[bot] merged 4 commits intoflutter:flutter-3.27-candidate.0from
hellohuanlin:cp3.27_webview_recursive_workaround
Dec 13, 2024
Merged

[CP][3.27][ios]enable the webview non tappable workaround by checking subviews recursively #57168#57172
auto-submit[bot] merged 4 commits intoflutter:flutter-3.27-candidate.0from
hellohuanlin:cp3.27_webview_recursive_workaround

Conversation

@hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Dec 12, 2024 •
edited
Loading

CP for #57168 and #57193

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#158961

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin changed the title Cp3.27 webview recursive workaround [CP][3.27][ios]enable the webview non tappable workaround by checking subviews recursively #57168 Dec 13, 2024
@hellohuanlin hellohuanlin mentioned this pull request Dec 13, 2024
Closed
@hellohuanlin
Copy link
Contributor Author

hellohuanlin commented Dec 13, 2024

I was able to verify this fixes flutter_inappwebview

@hellohuanlin
Copy link
Contributor Author

hellohuanlin commented Dec 13, 2024 •
edited
Loading

Turning to draft after verifying AdMob

Verified admob behavior.

@hellohuanlin hellohuanlin marked this pull request as draft December 13, 2024 16:37
@hellohuanlin hellohuanlin marked this pull request as ready for review December 13, 2024 19:03
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2024
@auto-submit auto-submit bot merged commit eed6905 into flutter:flutter-3.27-candidate.0 Dec 13, 2024
@hellohuanlin hellohuanlin mentioned this pull request Dec 15, 2024
Closed
2 tasks
phamnhuvu-dev pushed a commit to phamnhuvu-dev/engine that referenced this pull request Jan 7, 2025
@hellohuanlin @phamnhuvu-dev
[CP][3.27][ios]enable the webview non tappable workaround by checking…
f33d733 
… subviews recursively flutter#57168 (flutter#57172)

CP for flutter#57168 and flutter#57193

*List which issues are fixed by this PR. You must list at least one issue.*
flutter/flutter#158961

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hellohuanlin @cbracken @itsjustkevin