This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make git diff range more robust in format.sh#5813
Merged
liyuqian merged 3 commits intoflutter:masterfrom Jul 20, 2018
Merged
Conversation
The new approach follows flutter/flutter#19412 which is suggested by Cirrus in cirruslabs/cirrus-ci-docs#17
Contributor
Author
Contributor
Author
|
@gspencergoog : I want to drop the |
Contributor
|
In what cases does it cause problems? |
Contributor
Author
|
@gspencergoog : when my local branch HEAD is based on a commit earlier than FETCH_HEAD, |
Contributor
|
Oh, I see. Maybe we should try with --fork-point first, and fall back to plain merge-base if it fails. Only because --fork-point seems to be more conservative about getting the "right" commit. Or, we could try just leaving it off and see if we get any odd failures... |
Contributor
Author
|
Done. We now fall back to |
gspencergoog
approved these changes
Jul 20, 2018
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new approach follows flutter/flutter#19412 which is suggested by Cirrus in cirruslabs/cirrus-ci-docs#17