UILaunchStoryboardName nil crash fix by kangwang1988 · Pull Request #6234 · flutter/engine

kangwang1988 · 2018-09-12T12:02:13Z

Fix a crash when UILaunchStoryboardName is not specified in Info.plist(Some developers might prefer LaunchImage).

…t(Developers might prefer LaunchImage).

* flt_master: (39 commits) Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (#6216)" (#6232) Roll src/third_party/skia 1b5ece0..e70aed7 (1 commits) (#6231) Roll src/third_party/skia bd65955..1b5ece0 (22 commits) (#6229) Improve performance of performance overlay by caching. (#6225) Remove root_surface_transformation from PaintContext (#6213) Flutter roll for Dart. (#6227) Roll buldroot to a11c4fd (#6224) Revert "Roll buildroot to eba79bb (#6215)" (#6223) Roll src/third_party/skia 2bf7a7b..bd65955 (4 commits) (#6222) Roll src/third_party/skia 82bf310..2bf7a7b (1 commits) (#6221) Roll buildroot to eba79bb (#6215) Roll src/third_party/skia 5518e65..82bf310 (1 commits) (#6220) Roll src/third_party/skia 3c4d533..5518e65 (1 commits) (#6219) Roll src/third_party/skia 7891994..3c4d533 (1 commits) (#6218) Reapply "Some cleanups enabled by removing support for Dart 1." (#6216) Roll src/third_party/skia a2bc1ca..7891994 (9 commits) (#6217) Roll freetype2 to 6581fd3 (#6214) Roll Dart to ef72098. (#6212) Roll src/third_party/skia cd9d074..a2bc1ca (8 commits) (#6211) Roll src/third_party/skia 40c7c64..cd9d074 (6 commits) (#6210) ...

googlebot · 2018-09-12T12:02:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-09-12T12:02:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

jamesderlin · 2018-09-12T16:50:54Z

Can you please sign the CLA so that we can look at and discuss your change?

kangwang1988 · 2018-09-13T03:18:43Z

As to the cla, we are "Corporate signers".

Previously, I've also filed a pr in flutter repo.

My email is: [email protected] and we have a google group: alibaba-flutter-contributors

kangwang1988 · 2018-09-13T03:19:03Z

I signed it!

jamesderlin · 2018-09-13T04:02:10Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

        [[[NSBundle mainBundle] infoDictionary] objectForKey:@"UILaunchStoryboardName"];
+    if (launchStoryboardName == nil) {
+      return nil;
+    }


Oops. Sorry about that.

Note that this change won't let you use launch images as the Flutter splash screen. (Explicitly creating a UIView with the launch images and using that as the splash screen also would avoid the crash.)

flutter/engine@1231573...49ef4ad git log 1231573..49ef4ad --no-merges --oneline 49ef4ad Fix a crash when UILaunchStoryboardName is not specified in Info.plist (flutter/engine#6234) 2a433bc Roll src/third_party/skia 34e5e1b387f5..76bba35cbaa4 (2 commits) (flutter/engine#6243) 0c28a09 Roll src/third_party/skia 858f648bdae3..34e5e1b387f5 (8 commits) (flutter/engine#6241) 513f8fb Roll src/third_party/skia 16322637c477..858f648bdae3 (7 commits) (flutter/engine#6240) 9a7d721 Roll src/third_party/skia 44215505623b..16322637c477 (10 commits) (flutter/engine#6238) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@1231573...c0e6f6a git log 1231573..c0e6f6a --no-merges --oneline c0e6f6a Roll src/third_party/skia 76bba35cbaa4..46a5f6c28a34 (1 commits) (flutter/engine#6244) 49ef4ad Fix a crash when UILaunchStoryboardName is not specified in Info.plist (flutter/engine#6234) 2a433bc Roll src/third_party/skia 34e5e1b387f5..76bba35cbaa4 (2 commits) (flutter/engine#6243) 0c28a09 Roll src/third_party/skia 858f648bdae3..34e5e1b387f5 (8 commits) (flutter/engine#6241) 513f8fb Roll src/third_party/skia 16322637c477..858f648bdae3 (7 commits) (flutter/engine#6240) 9a7d721 Roll src/third_party/skia 44215505623b..16322637c477 (10 commits) (flutter/engine#6238) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter#6234) Some developers might prefer launch images.

kangwang1988 added 2 commits September 12, 2018 19:56

Fix a crash when UILaunchStoryboardName is not specified in Info.plis…

55ee521

…t(Developers might prefer LaunchImage).

googlebot added the cla: no label Sep 12, 2018

kangwang1988 changed the title ~~Ui launch storyboard name nil crash fix~~ UILaunchStoryboardName nil crash fix Sep 12, 2018

jamesderlin self-requested a review September 12, 2018 16:50

jamesderlin approved these changes Sep 13, 2018

View reviewed changes

jamesderlin merged commit 49ef4ad into flutter:master Sep 13, 2018

engine-flutter-autoroll mentioned this pull request Sep 13, 2018

Roll engine 12315736f9ca..49ef4adad327 (5 commits) flutter/flutter#21772

Closed

engine-flutter-autoroll mentioned this pull request Sep 13, 2018

Roll engine 12315736f9ca..c0e6f6a6e665 (6 commits) flutter/flutter#21788

Merged

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Fix a crash when UILaunchStoryboardName is not specified in Info.plist (

1985970

flutter#6234) Some developers might prefer launch images.

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Fix a crash when UILaunchStoryboardName is not specified in Info.plist (

7d077cc

flutter#6234) Some developers might prefer launch images.

kangwang1988 added a commit to XianyuTech/engine that referenced this pull request Nov 15, 2018

Fix a crash when UILaunchStoryboardName is not specified in Info.plist (

03d2d61

flutter#6234) Some developers might prefer launch images.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UILaunchStoryboardName nil crash fix#6234

UILaunchStoryboardName nil crash fix#6234
jamesderlin merged 2 commits intoflutter:masterfrom
FlutterRepo:UILaunchStoryboardName_nil_crash_fix

kangwang1988 commented Sep 12, 2018 •

edited

Loading

Uh oh!

googlebot commented Sep 12, 2018

Uh oh!

googlebot commented Sep 12, 2018

Uh oh!

jamesderlin commented Sep 12, 2018

Uh oh!

kangwang1988 commented Sep 13, 2018 •

edited

Loading

Uh oh!

kangwang1988 commented Sep 13, 2018

Uh oh!

jamesderlin Sep 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kangwang1988 commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Sep 12, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Sep 12, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

jamesderlin commented Sep 12, 2018

Uh oh!

kangwang1988 commented Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kangwang1988 commented Sep 13, 2018

Uh oh!

jamesderlin Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kangwang1988 commented Sep 12, 2018 •

edited

Loading

kangwang1988 commented Sep 13, 2018 •

edited

Loading