This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea.#6285
Merged
aam merged 2 commits intoflutter:masterfrom Sep 20, 2018
Merged
Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea.#6285aam merged 2 commits intoflutter:masterfrom
aam merged 2 commits intoflutter:masterfrom
Conversation
Changes since last roll: ``` c688d0c [frontend] When serializing compiled expression proc, clone type params first. 346895e Choose the right platform in the command-line fasta tool in strong mode 51d5304 [frontend] Honor embedSourceText option in incremental compiler. 06792cb Remove StackListener.popList 69cd7cb [infra] Add compare_results.dart and update_flakiness.dart. c3c4e63 Adjusted spec to use package syntax, thus eliminating bnf.sty 0315707 Add 'set' case to type_variable_conflict_test 00f2054 Add --repeat flag to test.py, so tests can be run multiple times cf5cdea Add J/K versions CommonElements and ElementEnvironment 1681241 Remove _ClassEnsurer a5b7181 Use json expectation files in dynamic tests d560887 Fix TypeError in Observatory 867c527 Debugging dart in methods with dynamic type arguments 2e3f17f Add support for the new mixin syntax to supertype constraint checking and resynthesis. 929b2fb Adjust status file to account for CustomIsolates test passing now. f0974ae Remove entry_points option from the test harness (should fix the precompiler bot failure). 296e4aa Split mixin_declaration_inference_valid_classes_test.dart into multiple tests. 2c427d3 Train the dartanalyzer on less source. 4127350 Detect references to instance variables without declared type. a077609 Cleanup some of the build rules to not use Dart 1 mode. 3463f94 Delete any existing version of a DevFS file before overwriting the file 7763ec3 Surface analyzer toplevel inference limitations as DDC errors. a386c07 [vm/aot] Add extra call specialization pass 8780174 Roll dart_style to 1.2.0. a890d95 [vm/compiler] Avoid !(x>y) -> x<=y on fp operands. bc79674 [vm/aot] Fix inferred type of implicitly initialized final fields 7df4900 Train the dartanalyzer tool on generating summaries. 80c1b88 Add copyright comments in resolution tests. bbe4952 Cache mapping from subtypes names to files where they are subtyped. cf67e40 Add test case reproducing issues flutter#34498 and flutter#34500. 81ce969 Enable implicit constructors with optional parameters in mixin applications. cb33106 Compare AnalysisOptions signatures in analyzer_cli. eb059a7 Keep analyzer-specific status entries together in language_2_analyzer.status 62ce86e Add --test-list and --repeat options to test.py, for deflaking 9e86c1a Normalize strong.status 3831da8 Include all problems in expectations a1bd501 Make input validation optional 6fe2723 Tweak parameters of ProcessedOptions 0a5d7b8 Update status files after de984e5. de984e5 Type checking for redirecting factories. 4134b95 [vm/tfa] Streamline handling of tear-offs in TFA d44ffba [vm/tfa] Stop accepting non-empty entry points json files 30f0026 [VM runtime] Fix type test: C is a subtype of C<FutureOr> (fixes flutter#34482). bbe8346 Test that type of the ListLiteral with two different enums is inferred. 37b41bd Update status files after d414815 d9fcaa3 Implement StreamTransformer.fromBind abb392f add Pubspec.dependencyOverrides c733ed7 firefix status for LayoutTests/fast/dom/Range/getClientRects-character_t01 d414815 Initial valid inference checks dcabf2c Test for mixin declaration isObject and tweaks for error verifier. ```
zanderso
reviewed
Sep 20, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2018
flutter/engine@2e8e96f...71457a6 git log 2e8e96f..71457a6 --no-merges --oneline 71457a6 Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea. (flutter/engine#6285) 1501359 Roll src/third_party/skia 1d6281d4bb47..9369031fde2d (27 commits) (flutter/engine#6284) f3d51b0 Fix Top, Left, and Right padding for fullscreen android apps. (flutter/engine#6282) 7ec1d21 Compute maxIntrinsicWidth based on the width of styled runs added to the line breaker (flutter/engine#6281) 2b25fd7 Don't use unix or win namespaces (flutter/engine#6277) 60c5bb8 Return null instead of throwing if an instance method is passed to PluginUtilities.getCallbackHandle (flutter/engine#6260) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2018
flutter/engine@2e8e96f...2302bea git log 2e8e96f..2302bea --no-merges --oneline 2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287) 71457a6 Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea. (flutter/engine#6285) 1501359 Roll src/third_party/skia 1d6281d4bb47..9369031fde2d (27 commits) (flutter/engine#6284) f3d51b0 Fix Top, Left, and Right padding for fullscreen android apps. (flutter/engine#6282) 7ec1d21 Compute maxIntrinsicWidth based on the width of styled runs added to the line breaker (flutter/engine#6281) 2b25fd7 Don't use unix or win namespaces (flutter/engine#6277) 60c5bb8 Return null instead of throwing if an instance method is passed to PluginUtilities.getCallbackHandle (flutter/engine#6260) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Member
|
FYI: This dart roll increased the Dart snapshot size for the Hello World app by 2KB, which is about 1%. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes since last roll: