This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for text shadows#6385
Merged
GaryQian merged 8 commits intoflutter:masterfrom Oct 12, 2018
Merged
Conversation
Contributor
Author
|
See flutter/flutter#22449 for framework-side integration |
Contributor
|
lgtm. Really appreciate the tests on the native side. We should wire up comparison of snapshots to golden fixtures soon. Care to file a bug for the same? @gspencergoog has some experience with golden tests in the framework and maybe we can get his help on the same for the engine. @Hixie for review of the Dart code. |
Hixie
reviewed
Sep 29, 2018
lib/ui/text.dart
Outdated
| /// A single text shadow. | ||
| /// | ||
| /// Multiple shadows are stacked together in a [TextStyle]. | ||
| class TextShadow { |
Contributor
There was a problem hiding this comment.
why TextShadow rather than Shadow? (Using Shadow would let BoxShadow inherit from it too.)
Contributor
Author
There was a problem hiding this comment.
This class is the dart:ui equivalent to shadows, and is only used for text. I didn't want the framework Shadow class be dependent on the dart:ui class that really only exists as a bridge from flutter to dart ui.
See shadow.dart and box_shadow.dart on the framework side for the inherited/generic version
Contributor
There was a problem hiding this comment.
I don't really see why we wouldn't want BoxShadow to inherit from the dart:ui class? Can you elaborate on that?
Contributor
Author
There was a problem hiding this comment.
I was thinking that the shadow class in dart:ui would provide things like serialization that would not be useful to the framework as a whole. Such methods would probably just add clutter to the API, as it is very specific to the use case of passing data to LibTxt. Also, I figured the framework itself could use the existence of a simple shadow class alongside the more advanced BoxShadow.
From a user's perspective, I think it makes more sense for them to import the painting package and have a Shadow than importing dart:ui for Shadow.
Overall, I think it keeps the code better encapsulated and doesn't provide niche API that would never be used.
Contributor
There was a problem hiding this comment.
The privates would be private, so the subclasses would be unaffected by them.
The painting package would re-export Shadow, they wouldn't know that it was there.
The problem with having three classes is that it's one third as many classes. It's also confusing that you create a "Shadow" to style text, but at some point it becomes a "TextShadow". Also that "Shadow" is the superclass of "BoxShadow" but not "TextShadow".
As far as I can tell, TextShadow is a strict subset of BoxShadow, so it seems to make sense to me to say that BoxShadow is-a TextShadow (renamed accordingly to Shadow).
Contributor
Author
There was a problem hiding this comment.
Ok, that makes sense. I'll make the changes!
Hixie
reviewed
Sep 29, 2018
Hixie
reviewed
Sep 29, 2018
lib/ui/text.dart
Outdated
| this.color = const Color(0xFF000000), | ||
| this.offset = Offset.zero, | ||
| this.blurRadius = 0.0, | ||
| }); |
Contributor
There was a problem hiding this comment.
should the constructor assert that these are non-null? (and maybe that the blurRadius is >=0?)
Hixie
reviewed
Sep 29, 2018
Hixie
reviewed
Sep 29, 2018
Hixie
reviewed
Sep 29, 2018
GaryQian
force-pushed
the
textshadow
branch
4 times, most recently
from
9f3a726 to
b444d3e
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...2bb3afa git log 50c2e69..2bb3afa --no-merges --oneline 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...a1bbea7 git log 50c2e69..a1bbea7 --no-merges --oneline a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...1242f6d git log 50c2e69..1242f6d --no-merges --oneline 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...e6887a4 git log 50c2e69..e6887a4 --no-merges --oneline e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...9033c39 git log 50c2e69..9033c39 --no-merges --oneline 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...f46b7b9 git log 50c2e69..f46b7b9 --no-merges --oneline f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...ef0b0f6 git log 50c2e69..ef0b0f6 --no-merges --oneline ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2018
flutter/engine@50c2e69...116072e git log 50c2e69..116072e --no-merges --oneline 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2018
flutter/engine@50c2e69...a4161c8 git log 50c2e69..a4161c8 --no-merges --oneline a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...ff93ccf git log 50c2e69..ff93ccf --no-merges --oneline ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...d4bae4c git log 50c2e69..d4bae4c --no-merges --oneline d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...964acaf git log 50c2e69..964acaf --no-merges --oneline 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 15, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...4ee7725 git log 50c2e69..4ee7725 --no-merges --oneline 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...32f417d git log 50c2e69..32f417d --no-merges --oneline 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...c645657 git log 50c2e69..c645657 --no-merges --oneline c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546) 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/Adds features for flutter/flutter#3402