This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[dart] Roll dart to a50dfd66980ed5c9aef9851fcc57557fb607769c.#6472
Merged
aam merged 3 commits intoflutter:masterfrom Oct 9, 2018
Merged
[dart] Roll dart to a50dfd66980ed5c9aef9851fcc57557fb607769c.#6472aam merged 3 commits intoflutter:masterfrom
aam merged 3 commits intoflutter:masterfrom
Conversation
Changes since last roll: ``` 89d7535 [test] Speed up get_vm_timeline_rpc_test.dart. de18295 Adjust some status files for the new build configurations added to the buildbots. 219dc1b Rework the class hierarchy of StrongModeStaticTypeAnalyzer2Test. dd7fec4 Issue 34693. Use isOverrideSubtypeOf() to check that the implemented member is a valid override of the member from the super-constraint. 26cab0a [VM/IO] The exit code handler thread should not try to get the exit codes for detached child processes. Currently we end up in a tight loop in the exit code handler when detached processes are created. 6edc759 [vm] Do not print if kernel isolate initialization is interrupted by VM shutdown. c8bda47 [standalone] Fix memory leaks when kernel isolate fails to launch from an app snapshot. 33485f8 [standalone] Fix leak when the kernel service produces a compile-time error. 7f531b5 Analyzer: Fix missing errors during (a)sync(*) yield of void. 4486bf5 [vm/bytecode] Fix return value for several BigInt intrinsics 28780d3 Convert element.dart to triple-slash comment style. b4b02a6 [vm] Include bytecode in core-jit and app-jit snapshots 2a3a5c8 [dart2js] Omit empty parts in --fast-startup f939503 [vm/aot] Make mixin deduplication transformation more robust wrt new mixins 5ea1d2f Convert idl.dart to triple-slash comment style. 69550e2 [dart/fuzzer] Increase #tests to 125 5b14445 [dart/fuzzer] Minor output tweaks 41a9c38 [vm, compiler] Shrink deopt stub and runtime call sequences. f96362c [dart2js] Smaller code by caching values b2d22be [vm, arm64] Take advantage of Fuchsia's lack of signal handlers. ca8809f Don't use variableElement.computeConstantValue() in ConstantVisitor. 9d150c6 Avoid a downcast error 0566f5f Remove unnecessary test status lines 0e7ca95 [gardening] Skip timing out bigint tests on slow configurations (flutter#31659) 127c3fe Handle data URIs in dart2js ```
Changes since last roll: ``` a50dfd6 Make --write-results not appear in reproduction commands 6c0b854 [VM] Fix canonicalization of doubles: Two doubles are canonicalized to the same value if they are idencial() f4ebebb Ignore runtime arguments in Fasta compiler configuration 1f916eb Mark a failing test 296c996 Remove outdated information from pkg/kernel/README.md 6cd25af Configure defines correctly in config_import_test.dart 4e4e9ec Implement int-to-double literal conversion. 79e8b3d Make importing two libraries with the same name a warning 89d7535 [test] Speed up get_vm_timeline_rpc_test.dart. de18295 Adjust some status files for the new build configurations added to the buildbots. 219dc1b Rework the class hierarchy of StrongModeStaticTypeAnalyzer2Test. dd7fec4 Issue 34693. Use isOverrideSubtypeOf() to check that the implemented member is a valid override of the member from the super-constraint. 26cab0a [VM/IO] The exit code handler thread should not try to get the exit codes for detached child processes. Currently we end up in a tight loop in the exit code handler when detached processes are created. 6edc759 [vm] Do not print if kernel isolate initialization is interrupted by VM shutdown. c8bda47 [standalone] Fix memory leaks when kernel isolate fails to launch from an app snapshot. 33485f8 [standalone] Fix leak when the kernel service produces a compile-time error. 7f531b5 Analyzer: Fix missing errors during (a)sync(*) yield of void. 4486bf5 [vm/bytecode] Fix return value for several BigInt intrinsics 28780d3 Convert element.dart to triple-slash comment style. b4b02a6 [vm] Include bytecode in core-jit and app-jit snapshots 2a3a5c8 [dart2js] Omit empty parts in --fast-startup f939503 [vm/aot] Make mixin deduplication transformation more robust wrt new mixins 5ea1d2f Convert idl.dart to triple-slash comment style. 69550e2 [dart/fuzzer] Increase #tests to 125 5b14445 [dart/fuzzer] Minor output tweaks 41a9c38 [vm, compiler] Shrink deopt stub and runtime call sequences. f96362c [dart2js] Smaller code by caching values b2d22be [vm, arm64] Take advantage of Fuchsia's lack of signal handlers. ca8809f Don't use variableElement.computeConstantValue() in ConstantVisitor. 9d150c6 Avoid a downcast error 0566f5f Remove unnecessary test status lines 0e7ca95 [gardening] Skip timing out bigint tests on slow configurations (flutter#31659) 127c3fe Handle data URIs in dart2js ```
sjindel-google
approved these changes
Oct 9, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2018
flutter/engine@69e9eb1...08af410 git log 69e9eb1..08af410 --no-merges --oneline 08af410 [dart] Roll dart to a50dfd66980ed5c9aef9851fcc57557fb607769c. (flutter/engine#6472) 25b8bbf Roll src/third_party/skia 817c01aecdc4..a41a74ac7994 (1 commits) (flutter/engine#6475) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2018
flutter/engine@69e9eb1...08af410 git log 69e9eb1..08af410 --no-merges --oneline 08af410 [dart] Roll dart to a50dfd66980ed5c9aef9851fcc57557fb607769c. (flutter/engine#6472) 25b8bbf Roll src/third_party/skia 817c01aecdc4..a41a74ac7994 (1 commits) (flutter/engine#6475) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.