An API for loading fonts from a buffer provided by the application by jason-simmons · Pull Request #6508 · flutter/engine

jason-simmons · 2018-10-11T22:19:36Z

No description provided.

chinmaygarde

lgtm once the font registration is moved to the IO thread with the call to loadFontFromList made async.

chinmaygarde · 2018-10-11T22:21:02Z

lib/ui/text.dart

+/// Loads a font from a buffer and makes it available for rendering text.
+///
+/// * `list`: A list of bytes containing the font file.
+/// * `fontFamily`: The family name of the font.  If this is not provided,


Can you specify if this is the postscript name or something else?

This name can be anything - it will be used to identify the font when building a TextStyle. Added a clarification.

chinmaygarde · 2018-10-11T22:21:29Z

lib/ui/text/font_collection.cc

+
+void LoadFontFromList(const tonic::Uint8List& font_data,
+                      std::string family_name) {
+  FontCollection& font_collection =


Bump this to the IO thread?

Kept this on the UI thread for now - it just parses the font's metadata and doesn't take much time, and it's expected to be used during initialization. We can move it to the IO thread if it becomes a bottleneck.

chinmaygarde · 2018-10-11T22:22:00Z

lib/ui/text.dart

+/// * `list`: A list of bytes containing the font file.
+/// * `fontFamily`: The family name of the font.  If this is not provided,
+///   then the family name will be extracted from the font file.
+void loadFontFromList(Uint8List list, {String fontFamily}) {


I think its better to make this an async call so that we can bump the font loading to the IO thread instead of doing the load in a frame workload.

Changed this to return a future.

flutter/engine@3ffa362...f2e7441 git log 3ffa362..f2e7441 --no-merges --oneline f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) 50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514) 8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513) c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...f2e7441 git log 50c2e69..f2e7441 --no-merges --oneline f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...a9076c7 git log 50c2e69..a9076c7 --no-merges --oneline a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...32841dd git log 50c2e69..32841dd --no-merges --oneline 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

Hixie · 2018-10-12T23:46:57Z

there was a suggested API for this in flutter/flutter#17910 which may be of interest.

see also flutter/flutter#19350

flutter/engine@50c2e69...75e8752 git log 50c2e69..75e8752 --no-merges --oneline 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...2bb3afa git log 50c2e69..2bb3afa --no-merges --oneline 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...a1bbea7 git log 50c2e69..a1bbea7 --no-merges --oneline a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...1242f6d git log 50c2e69..1242f6d --no-merges --oneline 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...e6887a4 git log 50c2e69..e6887a4 --no-merges --oneline e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...9033c39 git log 50c2e69..9033c39 --no-merges --oneline 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...f46b7b9 git log 50c2e69..f46b7b9 --no-merges --oneline f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...ef0b0f6 git log 50c2e69..ef0b0f6 --no-merges --oneline ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...116072e git log 50c2e69..116072e --no-merges --oneline 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...a4161c8 git log 50c2e69..a4161c8 --no-merges --oneline a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...ff93ccf git log 50c2e69..ff93ccf --no-merges --oneline ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...d4bae4c git log 50c2e69..d4bae4c --no-merges --oneline d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...964acaf git log 50c2e69..964acaf --no-merges --oneline 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...4ee7725 git log 50c2e69..4ee7725 --no-merges --oneline 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...32f417d git log 50c2e69..32f417d --no-merges --oneline 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...c645657 git log 50c2e69..c645657 --no-merges --oneline c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546) 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

Hixie · 2018-10-22T16:14:22Z

cc @GaryQian @jason-simmons We should update this API to match flutter/flutter#17910 so as to take into account the design issues that came up during the discussion in that bug.

googlebot added the cla: yes label Oct 11, 2018

jason-simmons requested a review from chinmaygarde October 11, 2018 22:19

chinmaygarde approved these changes Oct 11, 2018

View reviewed changes

jason-simmons force-pushed the font_dynamic_load branch from 93c4ac9 to 6c4dfbb Compare October 12, 2018 00:53

chinmaygarde approved these changes Oct 12, 2018

View reviewed changes

An API for loading fonts from a buffer provided by the application

3be28c2

jason-simmons force-pushed the font_dynamic_load branch from 6c4dfbb to 3be28c2 Compare October 12, 2018 17:11

jason-simmons merged commit f2e7441 into flutter:master Oct 12, 2018

engine-flutter-autoroll mentioned this pull request Oct 12, 2018

Roll engine 3ffa36295234..f2e7441b55d3 (10 commits) flutter/flutter#23022

Closed

engine-flutter-autoroll mentioned this pull request Oct 12, 2018

Roll engine 3ffa36295234..f2e7441b55d3 (10 commits) flutter/flutter#23023

Closed

engine-flutter-autoroll mentioned this pull request Oct 12, 2018

Roll engine 50c2e69daff4..f2e7441b55d3 (7 commits) flutter/flutter#23025

Closed

engine-flutter-autoroll mentioned this pull request Oct 12, 2018

Roll engine 50c2e69daff4..a9076c7e6b80 (8 commits) flutter/flutter#23028

Closed

engine-flutter-autoroll mentioned this pull request Oct 12, 2018

Roll engine 50c2e69daff4..32841dd89b92 (9 commits) flutter/flutter#23033

Closed

Hixie mentioned this pull request Oct 12, 2018

Add ability to dynamically load a font flutter/flutter#17910

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..75e875240e21 (12 commits) flutter/flutter#23035

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..2bb3afad8bf2 (13 commits) flutter/flutter#23037

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..a1bbea77cf6d (14 commits) flutter/flutter#23041

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..1242f6dfe11f (15 commits) flutter/flutter#23042

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..e6887a4121f7 (16 commits) flutter/flutter#23043

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..9033c39021f2 (17 commits) flutter/flutter#23046

Closed

This was referenced Oct 13, 2018

Roll engine 50c2e69daff4..f46b7b9713ca (18 commits) flutter/flutter#23048

Closed

Roll engine 50c2e69daff4..ef0b0f6e962b (19 commits) flutter/flutter#23059

Closed

engine-flutter-autoroll mentioned this pull request Oct 14, 2018

Roll engine 50c2e69daff4..116072e468c9 (20 commits) flutter/flutter#23065

Closed

This was referenced Oct 14, 2018

Roll engine 50c2e69daff4..a4161c8957fb (21 commits) flutter/flutter#23069

Closed

Roll engine 50c2e69daff4..ff93ccf473f2 (22 commits) flutter/flutter#23083

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..d4bae4ca4a95 (23 commits) flutter/flutter#23091

Closed

This was referenced Oct 15, 2018

Roll engine 50c2e69daff4..964acafebd32 (24 commits) flutter/flutter#23101

Closed

Roll engine 50c2e69daff4..4ee77256c0ab (25 commits) flutter/flutter#23111

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..32f417db0d56 (26 commits) flutter/flutter#23113

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..c6456570ab02 (27 commits) flutter/flutter#23120

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

An API for loading fonts from a buffer provided by the application#6508

An API for loading fonts from a buffer provided by the application#6508
jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons:font_dynamic_load

jason-simmons commented Oct 11, 2018

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde Oct 11, 2018

Uh oh!

jason-simmons Oct 12, 2018

Uh oh!

chinmaygarde Oct 11, 2018

Uh oh!

jason-simmons Oct 12, 2018

Uh oh!

chinmaygarde Oct 12, 2018

Uh oh!

chinmaygarde Oct 11, 2018

Uh oh!

jason-simmons Oct 12, 2018

Uh oh!

Hixie commented Oct 12, 2018

Uh oh!

Hixie commented Oct 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jason-simmons commented Oct 11, 2018

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

jason-simmons Oct 12, 2018

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

jason-simmons Oct 12, 2018

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Oct 12, 2018

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

jason-simmons Oct 12, 2018

Choose a reason for hiding this comment

Uh oh!

Hixie commented Oct 12, 2018

Uh oh!

Hixie commented Oct 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants