This repository was archived by the owner on Feb 25, 2025. It is now read-only.
DCHECK that clip layer's behavior isn't none#7659
Merged
liyuqian merged 1 commit intoflutter:masterfrom Feb 4, 2019
Merged
Conversation
This will further guard that the framework won't forget to set the clip behavior. This has been tested with the flutter/flutter framework `flutter test --local-engine=host_debug_unopt` to ensure a successful engine roll.
jason-simmons
approved these changes
Jan 31, 2019
Contributor
Author
|
Thanks Jason for the review! I'll wait for @GaryQian's manual engine roll to land before merging this PR. |
chinmaygarde
approved these changes
Feb 1, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2019
flutter/engine@85492c3...4812a2a git log 85492c3..4812a2a --no-merges --oneline 4812a2a DCHECK that clip layer's behavior isn't none (flutter/engine#7659) eaae8a6 Retained rendering in Fuchsia PhysicalShapeLayer (flutter/engine#6558) 1946082 Move Brightness definition to dart:ui (#27479) (flutter/engine#7678) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@85492c3...4812a2a git log 85492c3..4812a2a --no-merges --oneline 4812a2a DCHECK that clip layer&flutter#39;s behavior isn&flutter#39;t none (flutter/engine#7659) eaae8a6 Retained rendering in Fuchsia PhysicalShapeLayer (flutter/engine#6558) 1946082 Move Brightness definition to dart:ui (flutter#27479) (flutter/engine#7678) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will further guard that the framework won't forget to set the
clip behavior.
This has been tested with the flutter/flutter framework using
flutter test --local-engine=host_debug_unoptto ensure a successful engine roll.