DrawerItem, DrawerHeader should take a child instead of children#767
DrawerItem, DrawerHeader should take a child instead of children#767abarth merged 1 commit intoflutter:masterfrom
Conversation
These widgets were designed in CSS where you need to specify a layout model for
your children. This patch updates them to the modern style of just taking a
unique child.
Fixes #755
|
TBR @eseidelGoogle |
DrawerItem, DrawerHeader should take a child instead of children
There was a problem hiding this comment.
wrap these one to a line for consistency with the others. What I've been doing to get the indentation right in these cases is have the three lines after the [ indented by 4 instead of 2.
|
No need for the FlexDirection.horizontal arguments throughout. That's the default. |
|
LGTM other than those two issues |
|
I've been specifying flex direction at all my callsites just to be On Saturday, August 22, 2015, Ian Hickson [email protected] wrote:
|
Mostly formating and removing arguments with default values.
|
Followup in #769 |
|
@eseidelGoogle Would it help to have one flex class for horizontal and one for vertical? |
Mostly formating and removing arguments with default values.
Address review comments from #767
…iting Fix formatting of deprecation attributes in schema doc
3 participants
These widgets were designed in CSS where you need to specify a layout model for
your children. This patch updates them to the modern style of just taking a
unique child.
Fixes #755